Fix HTTP/2 write timeout ineffective against TCP-level network blackhole - #9702
Open
fabcipriano wants to merge 1 commit into
Open
Fix HTTP/2 write timeout ineffective against TCP-level network blackhole#9702fabcipriano wants to merge 1 commit into
fabcipriano wants to merge 1 commit into
Conversation
writeTimeout only interrupted flow-control waits via notifyAll(), which cannot unblock a thread parked inside a real socket write/flush. Guard those blocking writes so a timeout cancels the connection socket directly, and thread writeTimeoutMillis through newStream() so the initial HEADERS write is bounded even before the caller configures the new stream's own writeTimeout. Fixes lysine-dev#9237.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeTimeout only interrupted flow-control waits via notifyAll(), which cannot unblock a thread parked inside a real socket write/flush. Guard those blocking writes so a timeout cancels the connection socket directly, and thread writeTimeoutMillis through newStream() so the initial HEADERS write is bounded even before the caller configures the new stream's own writeTimeout.
Fixes #9237.