Skip to content

[WRONG BRANCH] gui: update Claude auto-compact default label to 829.8k - #312

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-gui-default-label-for-auto-compact-inv610
Draft

[WRONG BRANCH] gui: update Claude auto-compact default label to 829.8k#312
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-gui-default-label-for-auto-compact-inv610

Conversation

@luvs01

@luvs01 luvs01 commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The runtime default auto-compact window was raised to 829,800 tokens but the GUI still showed the empty/default select option as "350k (default)", which misleads users about the effective threshold.
  • Keep dashboard copy accurate and consistent with the runtime and manual-environment export to avoid user confusion and unexpected compaction behavior.

Description

  • Replace the stale "350k (default)" label with "829.8k (default)" in the English locale and the corresponding translated locale files (gui/src/i18n/{en,de,fr,ja,ko,ru,tr,zh,zh-TW}.ts).
  • Update the inline comment in gui/src/pages/ClaudeCode.tsx to note the effective 829.8k default shown by the empty select option.
  • This change updates visible copy only and preserves existing runtime behavior and values.

Testing

  • Ran the GUI unit tests with the repository-pinned Bun (../node_modules/.bin/bun test tests) and observed all tests pass (931 pass, 0 fail).
  • Ran bun run lint, bun run lint:i18n, and bun run build from gui/ and all checks completed successfully.
  • Validation used the repo-pinned Bun executable when the globally installed Bun was incompatible, and the focused GUI checks required by the repository i18n guidelines passed.

Codex Task

Summary by CodeRabbit

  • Updates
    • Updated the displayed default automatic compaction window from 350k to 829.8k.
    • Refreshed the setting label across supported languages, including English, German, French, Japanese, Korean, Russian, Turkish, Simplified Chinese, and Traditional Chinese.

@github-actions github-actions Bot added the intake: hygiene-blocked Deterministic PR hygiene checks failed label Aug 17, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Deterministic hygiene checks failed.

  • missing_regression_test — Behavior changed under src/ or gui/src/ without a test change. Add focused coverage or obtain test-exception-approved.

@github-actions github-actions Bot added the bug Something isn't working label Aug 17, 2026
@github-actions github-actions Bot changed the title gui: update Claude auto-compact default label to 829.8k [WRONG BRANCH] gui: update Claude auto-compact default label to 829.8k Aug 17, 2026
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev. UI screenshot required. hygiene: missing_regression_test.

What to do

  • Retarget this PR to dev — all contributions go to dev.
  • Add a screenshot of the UI change to the PR description.
  • Fix missing_regression_test — Behavior changed under src/ or gui/src/ without a test change. Add focused coverage or obtain test-exception-approved.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 17, 2026 09:20
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 078cd31a-3d71-41a2-bac3-8f92231bb9f7

📥 Commits

Reviewing files that changed from the base of the PR and between 9dcecfe and c7b62b5.

📒 Files selected for processing (10)
  • gui/src/i18n/de.ts
  • gui/src/i18n/en.ts
  • gui/src/i18n/fr.ts
  • gui/src/i18n/ja.ts
  • gui/src/i18n/ko.ts
  • gui/src/i18n/ru.ts
  • gui/src/i18n/tr.ts
  • gui/src/i18n/zh-TW.ts
  • gui/src/i18n/zh.ts
  • gui/src/pages/ClaudeCode.tsx

Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The change updates the displayed Claude auto-compaction default from 350k to 829.8k in the Claude Code page and nine localized UI labels.

Changes

Auto-compaction default

Layer / File(s) Summary
Update default auto-compaction labels
gui/src/pages/ClaudeCode.tsx, gui/src/i18n/*.ts
The documented default and localized claude.autoCompactDefault labels now display 829.8k instead of 350k. German, English, French, Japanese, Korean, Russian, Turkish, Simplified Chinese, and Traditional Chinese translations are updated.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c7b62

This updates the displayed auto-compact default from 350k to 829.8k without changing runtime behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the GUI change to update the Claude auto-compact default label to 829.8k.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 3
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch codex/fix-gui-default-label-for-auto-compact-inv610
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-gui-default-label-for-auto-compact-inv610

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7b62b5469

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread gui/src/i18n/de.ts
"claude.autoContextInert": "Inaktiv, weil in der Konfigurationsdatei ein alter Kontextgrößen-Wert (maxContextTokens) steht. Dort entfernen, um es wieder zu aktivieren.",
"claude.autoCompactWindow": "Punkt für Auto-Zusammenfassung",
"claude.autoCompactDefault": "350k (Standard)",
"claude.autoCompactDefault": "829.8k (Standard)",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Format the fractional default with the active locale

In locales that use a comma as the decimal separator, including German, French, Russian, and Turkish, the default option now displays the English-formatted 829.8k, while the other options are formatted from localeTag. This inconsistency first becomes visible because the new default is fractional; generate its numeric portion with a locale-aware formatter and keep only the translatable “default” text in the locale entry rather than duplicating technical units across translations.

AGENTS.md reference: gui/AGENTS.md:L22-L27

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex intake: hygiene-blocked Deterministic PR hygiene checks failed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant