[WRONG BRANCH] gui: update Claude auto-compact default label to 829.8k - #312
[WRONG BRANCH] gui: update Claude auto-compact default label to 829.8k#312luvs01 wants to merge 1 commit into
Conversation
|
⏳ DRAFT
What to do
Its title has been prefixed with |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe change updates the displayed Claude auto-compaction default from 350k to 829.8k in the Claude Code page and nine localized UI labels. ChangesAuto-compaction default
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates the displayed auto-compact default from 350k to 829.8k without changing runtime behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 3📝 Generate docstrings 💡
⚔️ Resolve merge conflicts 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7b62b5469
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "claude.autoContextInert": "Inaktiv, weil in der Konfigurationsdatei ein alter Kontextgrößen-Wert (maxContextTokens) steht. Dort entfernen, um es wieder zu aktivieren.", | ||
| "claude.autoCompactWindow": "Punkt für Auto-Zusammenfassung", | ||
| "claude.autoCompactDefault": "350k (Standard)", | ||
| "claude.autoCompactDefault": "829.8k (Standard)", |
There was a problem hiding this comment.
Format the fractional default with the active locale
In locales that use a comma as the decimal separator, including German, French, Russian, and Turkish, the default option now displays the English-formatted 829.8k, while the other options are formatted from localeTag. This inconsistency first becomes visible because the new default is fractional; generate its numeric portion with a locale-aware formatter and keep only the translatable “default” text in the locale entry rather than duplicating technical units across translations.
AGENTS.md reference: gui/AGENTS.md:L22-L27
Useful? React with 👍 / 👎.
Motivation
Description
gui/src/i18n/{en,de,fr,ja,ko,ru,tr,zh,zh-TW}.ts).gui/src/pages/ClaudeCode.tsxto note the effective829.8kdefault shown by the empty select option.Testing
../node_modules/.bin/bun test tests) and observed all tests pass (931 pass, 0 fail).bun run lint,bun run lint:i18n, andbun run buildfromgui/and all checks completed successfully.Codex Task
Summary by CodeRabbit