Skip to content

[WRONG BRANCH] fix(google): hydrate scoped replay signatures after routing - #303

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-scoped-replay-issue
Draft

[WRONG BRANCH] fix(google): hydrate scoped replay signatures after routing#303
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-scoped-replay-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The Responses parser performs replay-time lookup for provider-opaque tool-call signatures but is invoked before the route/provider/account/model scope is bound, so scoped lookups returned undefined and previously-remembered Google/Gemini thought signatures were not reattached on production requests.

Description

  • Add hydrateReplayThoughtSignatures(parsed) in src/responses/parser.ts which walks assistant message parts and restores providerMetadata from the scoped replay store when a complete parsed._reasoningReplayScope is available.
  • Invoke hydrateReplayThoughtSignatures(parsed) in src/server/responses/core.ts immediately after bindRouteReasoningReplayScope(...) so parser-side replay lookups can use the fully-bound scope.
  • Add a focused regression test in tests/google-signature-history-roundtrip.test.ts that verifies a parse-without-scope then bind+hydrate ordering restores the remembered thought signature for rebuilt Google requests.

Testing

  • Ran the focused tests bun test tests/google-signature-history-roundtrip.test.ts tests/reasoning-replay-scope-source.test.ts, and both passed.
  • Ran bun run typecheck and bun run privacy:scan, and both completed successfully.
  • A full bun run test attempt was started but the environment encountered unrelated external registry download errors and pre-existing fixture issues, so the complete suite was not fully run in this environment.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Limit details: You’ve used all 3 included reviews currently available under your plan.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: df5e30e0-461c-4432-abd4-4736685d6f47

📥 Commits

Reviewing files that changed from the base of the PR and between 2bd271f and e7dc657.

📒 Files selected for processing (3)
  • src/responses/parser.ts
  • src/server/responses/core.ts
  • tests/google-signature-history-roundtrip.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 17, 2026
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions github-actions Bot changed the title fix(google): hydrate scoped replay signatures after routing [WRONG BRANCH] fix(google): hydrate scoped replay signatures after routing Aug 17, 2026
@github-actions
github-actions Bot marked this pull request as draft August 17, 2026 05:11
@luvs01 luvs01 closed this Aug 19, 2026
@luvs01 luvs01 reopened this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant