[WRONG BRANCH] fix(cursor): preserve top-level apply_patch guidance - #302
[WRONG BRANCH] fix(cursor): preserve top-level apply_patch guidance#302luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughCode-mode guidance now computes nested-only tool names based on advertised tools. It omits ChangesCursor code-mode guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This narrowly adjusts Cursor guidance so a top-level apply_patch remains callable while nested-only helpers remain restricted; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
apply_patchtool is present.apply_patchas a nested-only helper, which could conflict with catalogs that actually advertiseapply_patchas a top-level tool.Description
codeModeNestedOnlyNameslist that excludesapply_patchwhenapply_patchis advertised, and use it in the code-mode guidance text so only genuinely nested helpers are forbade at top level.quotedNames(codeModeNestedOnlyNames)inbuildCursorToolGuidanceSystemNoteinsrc/adapters/cursor/tool-definitions.ts.keeps a visible top-level apply_patch callable in code modetotests/cursor-tool-definitions.test.tsthat verifies mixed catalogs advertiseapply_patchas callable and do not emit contradictory guidance.Testing
git diff --checkwhich reported no problems.bun test tests/cursor-tool-definitions.test.tswhich passed (25 pass, 0 fail).bun run typecheckwhich completed successfully; running the fullbun run testsurfaced unrelated failures/timeouts in other suites so the run was not used as verification for this focused change.Codex Task
Summary by CodeRabbit