[WRONG BRANCH] fix(lab): ensure manual Lab runs are cancellable during shutdown - #288
[WRONG BRANCH] fix(lab): ensure manual Lab runs are cancellable during shutdown#288luvs01 wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
@Wibias stepped down from developing opencodex, and repository permission was reduced to read access. Move him out of the current-maintainers table into a new Former maintainers section, drop him from the CODEOWNERS default-reviewer line and the four high-impact runtime paths, and record the change with the 2026-07-27 addition entry it closes. Nothing he authored is unwound: commits, merged pull requests, release-note attributions, and the code comments citing his reviews stay as they are.
37b3d5b to
bf4e97d
Compare
Motivation
/api/lab/automation/runexecutions from continuing pastdrainAndShutdownwhen Lab was never activated, by ensuring manual runs register a shutdown hook so they are cancelled like other Lab activities.Description
src/lab/automation/orchestrator.tsusingregisterOptionalShutdownHook(...)and detach it in afinallyblock so the hook cannot leak after completion.tests/lab-automation-review-regressions.test.tsthat starts a manual run, releases the activation lease, invokesrunOptionalShutdownHooks(), and asserts the manual run is cancelled.Testing
git diff --checkand created the fix commit (fix(lab): cancel manual runs during shutdown).bun run typecheck(local run) which completed without type errors for the edited modules.bun test tests/lab-automation-review-regressions.test.ts, which failed during module load with a Bun/runtimenode:zlibexport incompatibility (zstdDecompressSync) unrelated to this change; the failure prevented the full focused-suite execution in this environment.tests/optional-shutdown-hooks.test.ts(focused) was not fully exercised due to the prior runtime error; the new tests exercise the optional-shutdown-hooks path and were authored alongside the fix.Codex Task