Skip to content

[WRONG BRANCH] fix(lab): ensure manual Lab runs are cancellable during shutdown - #288

Draft
luvs01 wants to merge 2 commits into
mainfrom
codex/propose-fix-for-lab-shutdown-issue
Draft

[WRONG BRANCH] fix(lab): ensure manual Lab runs are cancellable during shutdown#288
luvs01 wants to merge 2 commits into
mainfrom
codex/propose-fix-for-lab-shutdown-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent manual /api/lab/automation/run executions from continuing past drainAndShutdown when Lab was never activated, by ensuring manual runs register a shutdown hook so they are cancelled like other Lab activities.

Description

  • Register a run-scoped optional shutdown hook for manual dispatches in src/lab/automation/orchestrator.ts using registerOptionalShutdownHook(...) and detach it in a finally block so the hook cannot leak after completion.
  • Add an outcome-level regression test in tests/lab-automation-review-regressions.test.ts that starts a manual run, releases the activation lease, invokes runOptionalShutdownHooks(), and asserts the manual run is cancelled.
  • Reset optional-shutdown-hooks in the test teardown to avoid cross-test leakage.

Testing

  • Ran git diff --check and created the fix commit (fix(lab): cancel manual runs during shutdown).
  • Ran bun run typecheck (local run) which completed without type errors for the edited modules.
  • Executed the focused test run bun test tests/lab-automation-review-regressions.test.ts, which failed during module load with a Bun/runtime node:zlib export incompatibility (zstdDecompressSync) unrelated to this change; the failure prevented the full focused-suite execution in this environment.
  • tests/optional-shutdown-hooks.test.ts (focused) was not fully exercised due to the prior runtime error; the new tests exercise the optional-shutdown-hooks path and were authored alongside the fix.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: eea13293-f932-4eea-99a5-d7240a892fa8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 15, 2026
@github-actions github-actions Bot changed the title fix(lab): ensure manual Lab runs are cancellable during shutdown [WRONG BRANCH] fix(lab): ensure manual Lab runs are cancellable during shutdown Aug 15, 2026
@github-actions

github-actions Bot commented Aug 15, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 15, 2026 02:45
@Wibias stepped down from developing opencodex, and repository permission was
reduced to read access. Move him out of the current-maintainers table into a
new Former maintainers section, drop him from the CODEOWNERS default-reviewer
line and the four high-impact runtime paths, and record the change with the
2026-07-27 addition entry it closes.

Nothing he authored is unwound: commits, merged pull requests, release-note
attributions, and the code comments citing his reviews stay as they are.
@luvs01 luvs01 closed this Aug 19, 2026
@luvs01 luvs01 reopened this Aug 19, 2026
@luvs01
luvs01 force-pushed the codex/propose-fix-for-lab-shutdown-issue branch from 37b3d5b to bf4e97d Compare August 19, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants