Skip to content

Add MsgPack feed unpacker codec#3

Open
moshen wants to merge 2 commits into
logstash-plugins:mainfrom
moshen:msgpack_feed
Open

Add MsgPack feed unpacker codec#3
moshen wants to merge 2 commits into
logstash-plugins:mainfrom
moshen:msgpack_feed

Conversation

@moshen

@moshen moshen commented Feb 6, 2015

Copy link
Copy Markdown

Comment thread lib/logstash/codecs/msgpack_feed.rb Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add documentation (using comments) on what this codec does in asciidoc? This will be converted to html and used as reference docs. Check this for an asciidoc guide: https://github.com/elastic/docs/blob/master/README.asciidoc#asciidoc-guide

@jordansissel jordansissel removed the O(2) label Jun 29, 2015
@moshen

moshen commented Jul 19, 2015

Copy link
Copy Markdown
Author

Updated. Will squash if desired.

@ghost

ghost commented Nov 2, 2015

Copy link
Copy Markdown

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@kares

kares commented Feb 27, 2020

Copy link
Copy Markdown
Contributor

Nice PR, seems to me like this would make sense as an option on the msgpack codec itself.
Rather than having a separate codec (which is also fine but should leave in its own repo than).

Is this considered alive by the author (after 5️⃣ years)?

@moshen

moshen commented Feb 27, 2020

Copy link
Copy Markdown
Author

I don't know about "alive", since I've archived my other logstash projects since I haven't used it in years. I think I made this a separate codec because everything else depends on a newline delimiter, but I may be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants