Refactor presentation files#234
Open
samuelwei wants to merge 8 commits into
Open
Conversation
samuelwei
force-pushed
the
refactor-presentation-files
branch
from
February 18, 2026 15:54
9c73ecc to
46c2108
Compare
samuelwei
force-pushed
the
refactor-presentation-files
branch
from
July 14, 2026 16:27
d2f0671 to
807a026
Compare
Author
|
@FelixJacobi What do you think about this approach? (Using a dedicated class and deprecating the many parameters) |
FelixJacobi
requested changes
Jul 20, 2026
|
|
||
| use BigBlueButton\Util\SimpleXMLElementExtended; | ||
|
|
||
| class InlinePresentation extends Presentation |
Member
There was a problem hiding this comment.
Suggested change
| class InlinePresentation extends Presentation | |
| final class InlinePresentation extends Presentation |
|
|
||
| use BigBlueButton\Util\SimpleXMLElementExtended; | ||
|
|
||
| class UrlPresentation extends Presentation |
Member
There was a problem hiding this comment.
Suggested change
| class UrlPresentation extends Presentation | |
| final class UrlPresentation extends Presentation |
| * @method string getClientSettingsOverride() | ||
| * @method $this setClientSettingsOverride(string $clientSettingsOverride) | ||
| */ | ||
| class CreateMeetingParameters extends MetaParameters |
Member
There was a problem hiding this comment.
Signature changes to existing methods of this Class are a breaking change since this class isn't final. We should mark it @final for next major release.
| /** | ||
| * @return $this | ||
| */ | ||
| public function addPresentation(string|Presentation $nameOrUrlOrPresentation, ?string $content = null, ?string $filename = null): self |
Member
There was a problem hiding this comment.
Sadly: Breaking change :/ . I need to think about a solution. Maybe we must move this to a new major version or add a new method.
Author
There was a problem hiding this comment.
We also need a major version for #243, as the parameter and return type changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
downloadable,removableandcurrentattribute for pre-uploaded slides in create api callBased on #228, extended to to more complete PR and change
Official docs: bigbluebutton/bigbluebutton#24657 updated