fix(#650): bind UUID parameters for PostgreSQL ADBC#651
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 77.06% 77.09% +0.02%
==========================================
Files 475 475
Lines 67206 67363 +157
Branches 10073 9209 -864
==========================================
+ Hits 51794 51935 +141
- Misses 12017 12030 +13
- Partials 3395 3398 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
cofin
marked this pull request as ready for review
July 22, 2026 16:21
Return the compiled SQL and parameters untouched when every requested ordinal already carries an authoritative non-UUID cast, so SQL text only changes when a cast is actually added and batch rows are never copied for a no-op rewrite. Treat unrecognized execute_many row shapes as non-UUID batches instead of raising; shape validation stays with the statement pipeline, which already rejects ragged batches before the rewrite runs. Normalize the postgresql dialect alias before the memoized rewrite so both spellings share one cache entry, and document that the helper is memoized per statement shape: the deliberate second parse of compiled SQL happens once per (sql, ordinals, dialect) and repeated executions reuse the cached rewrite. Quote the remaining union annotations and mark the UUID type tuple Final to match module conventions. Refs #650.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pgvectorandparadedbdialects so their custom operators survive the rewriteadbc/core.pyand keep the driver integration point smallFixes #650.
Testing
make install-compiled: passed (178compiled modules)make lint: passed, including mypy, pyright, pre-commit, and slotscheckDocumentation