st: Limit texture loading to 9 parallel operations - #13947
Open
leigh123linux wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent change in Glycin exposed this issue in the texture loading
code. GTask is not supposed to handle more than a few hundreds of
parallel tasks, and yet, StTextureCache was loading every async
request immediately. This may cause the GTask thread scheduler to
starve, and the most visible indication that this is happening are
icons in Cinnamon that never finish loading.
Limit the number of textures loading in parallel to 9. The added
time to load icons is negligible, and is offset by loading them
faster, since we're not hitting the disk with hundreds of random
reads at the same time.
Based on https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4349
I used Claude to port the change to cinnamon.