loop: three small cleanups - #1238
Open
blktests-ci-kpd[bot] wants to merge 3 commits into
Open
Conversation
Author
|
Upstream branch: ba285ed Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/series/1154388/ conflict: |
Author
|
Upstream branch: ba285ed |
blktests-ci-kpd
Bot
force-pushed
the
series/1151520=>for-next
branch
from
September 8, 2026 15:51
45050f3 to
11d803e
Compare
blktests-ci-kpd
Bot
force-pushed
the
for-next_base
branch
from
September 9, 2026 07:40
a7792e9 to
d7f8d66
Compare
Author
|
Upstream branch: dd660a0 |
blktests-ci-kpd
Bot
force-pushed
the
series/1151520=>for-next
branch
from
September 9, 2026 08:11
11d803e to
aa5df9e
Compare
blktests-ci-kpd
Bot
force-pushed
the
for-next_base
branch
from
September 10, 2026 15:29
d7f8d66 to
60818a6
Compare
added 3 commits
September 10, 2026 16:01
The kerneldoc of loop_set_size() points readers at loop_validate_size(), which does not exist in the tree. Drop the reference. Signed-off-by: Tao Cui <cuitao@kylinos.cn> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Christoph Hellwig <hch@lst.de>
simple_strtol() is deprecated and swallows errors. Use kstrtoint() in the max_loop setup code; an invalid option keeps the default and now says so. Only mark max_loop_specified when the option was parsed successfully. With simple_strtol() a garbage string yields max_loop = 0, and loop_probe()'s "max_loop_specified && max_loop" check short-circuits on 0, so legacy autoloading is not capped. Keeping max_loop at its default while still setting max_loop_specified would instead turn the default into a hard upper bound for dynamic device creation. This mirrors what max_loop_param_set_int() already does for the module parameter. Signed-off-by: Tao Cui <cuitao@kylinos.cn>
lo_req_flush() never uses its request argument. Drop it. Signed-off-by: Tao Cui <cuitao@kylinos.cn> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Christoph Hellwig <hch@lst.de>
Author
|
Upstream branch: 9dcbf66 |
blktests-ci-kpd
Bot
force-pushed
the
series/1151520=>for-next
branch
from
September 10, 2026 16:01
aa5df9e to
977bf06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: loop: three small cleanups
version: 1
url: https://patchwork.kernel.org/series/1154388/