Skip to content

blk-mq-dma: kernel-doc fixes - #1146

Open
blktests-ci-kpd[bot] wants to merge 2 commits into
linus-master_basefrom
series/1146755=>linus-master
Open

blk-mq-dma: kernel-doc fixes#1146
blktests-ci-kpd[bot] wants to merge 2 commits into
linus-master_basefrom
series/1146755=>linus-master

Conversation

@blktests-ci-kpd

Copy link
Copy Markdown

Pull request for series with
subject: blk-mq-dma: kernel-doc fixes
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1146755

@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: 3aa1dca
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146755
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the linus-master_base branch 2 times, most recently from d89ab11 to fdba928 Compare August 16, 2026 18:34
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: fd923b3
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146755
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from 3074e68 to 5d30e7c Compare August 16, 2026 19:33
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: fd923b3
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146755
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from 5d30e7c to 0b0220c Compare August 17, 2026 07:53
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: 8d3ae59
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146755
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from 0b0220c to 262ec73 Compare August 17, 2026 14:19
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: bd5f485
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146755
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from 262ec73 to 4b9412a Compare August 19, 2026 05:29
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: 66498c7
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146755
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from 4b9412a to 4e97d62 Compare August 25, 2026 03:48
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: 502d457
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146755
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from 4e97d62 to d6912b3 Compare August 26, 2026 21:07
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: cf72cbb
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146755
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from d6912b3 to 378d1b9 Compare August 29, 2026 07:06
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: cee9395
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146755
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from 378d1b9 to f5591b6 Compare August 31, 2026 10:53
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: 89a3129
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146755
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from f5591b6 to 51c20fb Compare September 2, 2026 09:24
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: bc35965
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146755
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from 51c20fb to 2b1ab3e Compare September 4, 2026 06:39
blktests-ci-kpd Bot pushed a commit that referenced this pull request Sep 7, 2026
MDS session OPEN handling replaces mdsc->s_cap_auths under
mdsc->mutex, freeing the previous array and its strings.

ceph_mds_check_access() traverses this array without holding the
mutex.  A concurrent session reopen can therefore free the array while
it is being inspected, resulting in a use-after-free like this:

  Unable to handle kernel paging request at virtual address 003aaad64b2c8bb9
  [...]
  Internal error: Oops: 0000000096000004 [#1]  SMP
  Modules linked in:
  CPU: 56 UID: 2953037534 PID: 1253231 Comm: php-cgi8.4 Not tainted 6.18.45-i2-ampere #1146 NONE
  [..]
  pc : ceph_mds_check_access+0xd4/0x550
  lr : ceph_mds_check_access+0xc8/0x550
  [...]
  Call trace:
   ceph_mds_check_access+0xd4/0x550 (P)
   ceph_atomic_open+0x138/0xbe8
   path_openat+0xa24/0xfa8
   do_filp_open+0x94/0x158
   do_sys_openat2+0x88/0xf8

Cc: stable@vger.kernel.org
Fixes: 596afb0 ("ceph: add ceph_mds_check_access() helper")
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
Reviewed-by: Alex Markuze <amarkuze@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: df29080
series: https://patchwork.kernel.org/series/1146755/
version: 1

Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/series/1146755/
error message:

Cmd('git') failed due to: exit code(128)
  cmdline: git am --3way
  stdout: 'Patch is empty.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To record the empty patch as an empty commit, run "git am --allow-empty".
To restore the original branch and stop patching, run "git am --abort".'

conflict:


@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: 28924df
series: https://patchwork.kernel.org/series/1146755/
version: 1

@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: 893e117
series: https://patchwork.kernel.org/series/1146755/
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from 9bc714b to c4e4d63 Compare September 9, 2026 08:24
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: 50d05c7
series: https://patchwork.kernel.org/series/1146755/
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from c4e4d63 to 39d2d38 Compare September 10, 2026 15:55
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: 5225b8e
series: https://patchwork.kernel.org/series/1146755/
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from 39d2d38 to 22f66dc Compare September 12, 2026 02:55
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: 2f0c1cf
series: https://patchwork.kernel.org/series/1146755/
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from 22f66dc to 8305727 Compare September 13, 2026 10:24
@blktests-ci-kpd

Copy link
Copy Markdown
Author

Upstream branch: 2f0c1cf
series: https://patchwork.kernel.org/series/1146755/
version: 1

blk_rq_integrity_dma_map_iter_next() documents a @State parameter it
has never had.  It takes (req, dma_dev, iter), as declared in
include/linux/blk-integrity.h, so scripts/kernel-doc reports an "Excess
function parameter 'state' description" warning at
block/blk-mq-dma.c:379.

The wrapped summary lines of both integrity helpers also indent with
tabs directly after "* ", which checkpatch flags as:

  block/blk-mq-dma.c:320: WARNING: please, no space before tabs
  block/blk-mq-dma.c:361: WARNING: please, no space before tabs

Drop the stale parameter description and use spaces for the alignment;
the rendered output is unchanged.  No functional change.

Both issues were found by running scripts/kernel-doc and
scripts/checkpatch.pl over block/, and verified against the prototype
in include/linux/blk-integrity.h.

Fixes: fec9b16 ("blk-mq-dma: add scatter-less integrity data DMA mapping")
Assisted-by: Claude:claude-opus-5 kernel-doc checkpatch
Signed-off-by: Bryan Boquel <boquelbryan6@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
blk_rq_dma_map_iter_start() and blk_rq_dma_map_iter_next() both
document their return value as "%true ft it did map a segment", where
"ft" should read "if".  The two integrity variants further down spell
it correctly.

No functional change.

Fixes: 858299d ("block: add scatterlist-less DMA mapping helpers")
Assisted-by: Claude:claude-opus-5
Signed-off-by: Bryan Boquel <boquelbryan6@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146755=>linus-master branch from 8305727 to d022d70 Compare September 13, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant