blk-mq-dma: kernel-doc fixes - #1146
Conversation
|
Upstream branch: 3aa1dca |
d89ab11 to
fdba928
Compare
|
Upstream branch: fd923b3 |
3074e68 to
5d30e7c
Compare
|
Upstream branch: fd923b3 |
5d30e7c to
0b0220c
Compare
fdba928 to
60442a3
Compare
|
Upstream branch: 8d3ae59 |
0b0220c to
262ec73
Compare
60442a3 to
3df366e
Compare
|
Upstream branch: bd5f485 |
262ec73 to
4b9412a
Compare
3df366e to
5dd70cb
Compare
|
Upstream branch: 66498c7 |
4b9412a to
4e97d62
Compare
5dd70cb to
055a766
Compare
|
Upstream branch: 502d457 |
4e97d62 to
d6912b3
Compare
055a766 to
341ae8c
Compare
|
Upstream branch: cf72cbb |
d6912b3 to
378d1b9
Compare
341ae8c to
940e422
Compare
|
Upstream branch: cee9395 |
378d1b9 to
f5591b6
Compare
940e422 to
3cab524
Compare
|
Upstream branch: 89a3129 |
f5591b6 to
51c20fb
Compare
3cab524 to
8242bf1
Compare
|
Upstream branch: bc35965 |
51c20fb to
2b1ab3e
Compare
MDS session OPEN handling replaces mdsc->s_cap_auths under mdsc->mutex, freeing the previous array and its strings. ceph_mds_check_access() traverses this array without holding the mutex. A concurrent session reopen can therefore free the array while it is being inspected, resulting in a use-after-free like this: Unable to handle kernel paging request at virtual address 003aaad64b2c8bb9 [...] Internal error: Oops: 0000000096000004 [#1] SMP Modules linked in: CPU: 56 UID: 2953037534 PID: 1253231 Comm: php-cgi8.4 Not tainted 6.18.45-i2-ampere #1146 NONE [..] pc : ceph_mds_check_access+0xd4/0x550 lr : ceph_mds_check_access+0xc8/0x550 [...] Call trace: ceph_mds_check_access+0xd4/0x550 (P) ceph_atomic_open+0x138/0xbe8 path_openat+0xa24/0xfa8 do_filp_open+0x94/0x158 do_sys_openat2+0x88/0xf8 Cc: stable@vger.kernel.org Fixes: 596afb0 ("ceph: add ceph_mds_check_access() helper") Signed-off-by: Max Kellermann <max.kellermann@ionos.com> Reviewed-by: Alex Markuze <amarkuze@redhat.com> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
8242bf1 to
5b28f57
Compare
|
Upstream branch: df29080 Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/series/1146755/ conflict: |
5b28f57 to
4ddd216
Compare
|
Upstream branch: 28924df |
2b1ab3e to
9bc714b
Compare
4ddd216 to
00cc4ca
Compare
|
Upstream branch: 893e117 |
9bc714b to
c4e4d63
Compare
00cc4ca to
7efd8cd
Compare
|
Upstream branch: 50d05c7 |
c4e4d63 to
39d2d38
Compare
7efd8cd to
a0aeca9
Compare
|
Upstream branch: 5225b8e |
39d2d38 to
22f66dc
Compare
a0aeca9 to
772381e
Compare
|
Upstream branch: 2f0c1cf |
22f66dc to
8305727
Compare
772381e to
0224dee
Compare
|
Upstream branch: 2f0c1cf |
blk_rq_integrity_dma_map_iter_next() documents a @State parameter it has never had. It takes (req, dma_dev, iter), as declared in include/linux/blk-integrity.h, so scripts/kernel-doc reports an "Excess function parameter 'state' description" warning at block/blk-mq-dma.c:379. The wrapped summary lines of both integrity helpers also indent with tabs directly after "* ", which checkpatch flags as: block/blk-mq-dma.c:320: WARNING: please, no space before tabs block/blk-mq-dma.c:361: WARNING: please, no space before tabs Drop the stale parameter description and use spaces for the alignment; the rendered output is unchanged. No functional change. Both issues were found by running scripts/kernel-doc and scripts/checkpatch.pl over block/, and verified against the prototype in include/linux/blk-integrity.h. Fixes: fec9b16 ("blk-mq-dma: add scatter-less integrity data DMA mapping") Assisted-by: Claude:claude-opus-5 kernel-doc checkpatch Signed-off-by: Bryan Boquel <boquelbryan6@gmail.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
blk_rq_dma_map_iter_start() and blk_rq_dma_map_iter_next() both document their return value as "%true ft it did map a segment", where "ft" should read "if". The two integrity variants further down spell it correctly. No functional change. Fixes: 858299d ("block: add scatterlist-less DMA mapping helpers") Assisted-by: Claude:claude-opus-5 Signed-off-by: Bryan Boquel <boquelbryan6@gmail.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
8305727 to
d022d70
Compare
Pull request for series with
subject: blk-mq-dma: kernel-doc fixes
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1146755