Skip to content

virtio-blk: clamp max_segments when indirect descriptors are disabled - #1140

Open
blktests-ci-kpd[bot] wants to merge 1 commit into
linus-master_basefrom
series/1146019=>linus-master
Open

virtio-blk: clamp max_segments when indirect descriptors are disabled#1140
blktests-ci-kpd[bot] wants to merge 1 commit into
linus-master_basefrom
series/1146019=>linus-master

Conversation

@blktests-ci-kpd

@blktests-ci-kpd blktests-ci-kpd Bot commented Aug 14, 2026

Copy link
Copy Markdown

Pull request for series with
subject: virtio-blk: clamp max_segments when indirect descriptors are disabled
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1146019

@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 14, 2026

Copy link
Copy Markdown
Author

Upstream branch: 3aa1dca
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146019
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the linus-master_base branch 2 times, most recently from d89ab11 to fdba928 Compare August 16, 2026 18:34
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 16, 2026

Copy link
Copy Markdown
Author

Upstream branch: fd923b3
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146019
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from 625e486 to 3dcc987 Compare August 16, 2026 19:39
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: fd923b3
series: https://patchwork.kernel.org/project/linux-block/list/?series=1147236
version: 2

@blktests-ci-kpd blktests-ci-kpd Bot added V2 and removed V1 labels Aug 17, 2026
@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from 3dcc987 to 2885cbd Compare August 17, 2026 13:52
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 8d3ae59
series: https://patchwork.kernel.org/project/linux-block/list/?series=1147236
version: 2

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from 2885cbd to 415506d Compare August 17, 2026 16:26
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 8d3ae59
series: https://patchwork.kernel.org/project/linux-block/list/?series=1147236
version: 2

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from 415506d to 2c28ba2 Compare August 17, 2026 19:54
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Upstream branch: bd5f485
series: https://patchwork.kernel.org/project/linux-block/list/?series=1147236
version: 2

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from 2c28ba2 to c41174f Compare August 19, 2026 05:35
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Upstream branch: bd5f485
series: https://patchwork.kernel.org/project/linux-block/list/?series=1147236
version: 2

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from c41174f to 61e14c8 Compare August 19, 2026 06:33
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 25, 2026

Copy link
Copy Markdown
Author

Upstream branch: 66498c7
series: https://patchwork.kernel.org/project/linux-block/list/?series=1147236
version: 2

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from 61e14c8 to 0d52ec9 Compare August 25, 2026 03:50
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 26, 2026

Copy link
Copy Markdown
Author

Upstream branch: 502d457
series: https://patchwork.kernel.org/project/linux-block/list/?series=1147236
version: 2

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from 0d52ec9 to 12ccd2f Compare August 26, 2026 21:09
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 29, 2026

Copy link
Copy Markdown
Author

Upstream branch: cf72cbb
series: https://patchwork.kernel.org/project/linux-block/list/?series=1147236
version: 2

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from 12ccd2f to 413b17e Compare August 29, 2026 07:08
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Upstream branch: cee9395
series: https://patchwork.kernel.org/project/linux-block/list/?series=1147236
version: 2

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from 413b17e to 4267811 Compare August 31, 2026 10:55
@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 2, 2026

Copy link
Copy Markdown
Author

Upstream branch: 89a3129
series: https://patchwork.kernel.org/project/linux-block/list/?series=1147236
version: 2

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from 4267811 to 176a667 Compare September 2, 2026 09:27
@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 4, 2026

Copy link
Copy Markdown
Author

Upstream branch: bc35965
series: https://patchwork.kernel.org/project/linux-block/list/?series=1147236
version: 2

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from 176a667 to f201f7a Compare September 4, 2026 06:41
@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 7, 2026

Copy link
Copy Markdown
Author

Upstream branch: df29080
series: https://patchwork.kernel.org/series/1147236/
version: 2

Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/series/1147236/
error message:

Cmd('git') failed due to: exit code(128)
  cmdline: git am --3way
  stdout: 'Patch is empty.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To record the empty patch as an empty commit, run "git am --allow-empty".
To restore the original branch and stop patching, run "git am --abort".'

conflict:

@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 8, 2026

Copy link
Copy Markdown
Author

Upstream branch: 28924df
series: https://patchwork.kernel.org/series/1147236/
version: 2

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from f201f7a to 3fbf647 Compare September 8, 2026 16:31
@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 9, 2026

Copy link
Copy Markdown
Author

Upstream branch: 893e117
series: https://patchwork.kernel.org/series/1147236/
version: 2

@thjnk kernel-patches-daemon
virtio-blk: clamp max_segments when indirect descriptors are disabled
90e3c3f 
When VIRTIO_RING_F_INDIRECT_DESC is not negotiated by the host, every
scatter-gather segment in a request must consume a physical slot in
the virtqueue ring.

If the host does not advertise VIRTIO_BLK_F_SEG_MAX and provides a small
virtqueue (e.g. 128 descriptors on QNX Hypervisor), the block layer
defaults max_segments to BLK_MAX_SEGMENTS (1024). When a multi-page
compound bio arrives from the page cache, virtqueue_add_split() rejects
the request with -ENOSPC and triggers:

  WARNING: at drivers/virtio/virtio_ring.c:1493 virtqueue_add+...
  WARN_ON_ONCE(total_sg > vq->split.vring.num && !vq->indirect);

This permanently wedges the blk-mq queue and blocks all subsequent disk
I/O in uninterruptible sleep (D state).

Automatically clamp sg_elems to (ring_size - 2) when indirect
descriptors are disabled.

Signed-off-by: Sergii Ushakov <sergiiushakov@google.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1146019=>linus-master branch from 3fbf647 to 90e3c3f Compare September 9, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

linus-master new V2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thjnk