Skip to content

nvme: refuse an unsolicited format change on a namespace that is in use - #1123

Open
blktests-ci-kpd[bot] wants to merge 1 commit into
linus-master_basefrom
series/1144288=>linus-master
Open

nvme: refuse an unsolicited format change on a namespace that is in use#1123
blktests-ci-kpd[bot] wants to merge 1 commit into
linus-master_basefrom
series/1144288=>linus-master

Conversation

@blktests-ci-kpd

@blktests-ci-kpd blktests-ci-kpd Bot commented Aug 11, 2026

Copy link
Copy Markdown

Pull request for series with
subject: nvme: refuse an unsolicited format change on a namespace that is in use
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1144288

@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 11, 2026

Copy link
Copy Markdown
Author

Upstream branch: d58772d
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144288
version: 1

@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 12, 2026

Copy link
Copy Markdown
Author

Upstream branch: f5bbbfe
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144288
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from 359de19 to e0856cc Compare August 12, 2026 13:50
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 12, 2026

Copy link
Copy Markdown
Author

Upstream branch: 3d6d817
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144288
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from e0856cc to 02cdf03 Compare August 12, 2026 19:38
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 13, 2026

Copy link
Copy Markdown
Author

Upstream branch: 3aa1dca
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144288
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from 02cdf03 to 694d1db Compare August 13, 2026 19:54
@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the linus-master_base branch 2 times, most recently from d89ab11 to fdba928 Compare August 16, 2026 18:34
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 16, 2026

Copy link
Copy Markdown
Author

Upstream branch: fd923b3
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144288
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from 694d1db to 4fef557 Compare August 16, 2026 19:54
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 8d3ae59
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144288
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from 4fef557 to b6b19ff Compare August 17, 2026 16:42
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Upstream branch: bd5f485
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144288
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from b6b19ff to bd4d930 Compare August 19, 2026 05:57
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 25, 2026

Copy link
Copy Markdown
Author

Upstream branch: 66498c7
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144288
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from bd4d930 to 87f6880 Compare August 25, 2026 03:54
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 26, 2026

Copy link
Copy Markdown
Author

Upstream branch: 502d457
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144288
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from 87f6880 to fdab42b Compare August 26, 2026 21:14
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 29, 2026

Copy link
Copy Markdown
Author

Upstream branch: cf72cbb
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144288
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from fdab42b to 8020848 Compare August 29, 2026 07:12
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Upstream branch: cee9395
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144288
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from 8020848 to b3b99dd Compare August 31, 2026 10:58
@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 2, 2026

Copy link
Copy Markdown
Author

Upstream branch: 89a3129
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144288
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from b3b99dd to 20e32f8 Compare September 2, 2026 09:31
@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 4, 2026

Copy link
Copy Markdown
Author

Upstream branch: bc35965
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144288
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from 20e32f8 to 9b3646e Compare September 4, 2026 06:45
@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 7, 2026

Copy link
Copy Markdown
Author

Upstream branch: df29080
series: https://patchwork.kernel.org/series/1144288/
version: 1

Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/series/1144288/
error message:

Cmd('git') failed due to: exit code(128)
  cmdline: git am --3way
  stdout: 'Patch is empty.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To record the empty patch as an empty commit, run "git am --allow-empty".
To restore the original branch and stop patching, run "git am --abort".'

conflict:

@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 8, 2026

Copy link
Copy Markdown
Author

Upstream branch: 28924df
series: https://patchwork.kernel.org/series/1144288/
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from 9b3646e to 1c1da3b Compare September 8, 2026 16:33
@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 9, 2026

Copy link
Copy Markdown
Author

Upstream branch: 893e117
series: https://patchwork.kernel.org/series/1144288/
version: 1

@ChaoShi001 kernel-patches-daemon
nvme: refuse an unsolicited format change on a namespace that is in use
4ed3bfb 
A namespace can report a new LBA format or metadata size on revalidation.
The host still holds cached data, queued bios and integrity buffers built
for the old geometry.  Adopting the new one reinterprets all of it.

Freezing the queue does not help.  The request is already complete when
the integrity verify is handed to kintegrityd, so the freeze drains while
that work is still pending.  The verify then walks a buffer sized for the
old metadata_size using the new step size.  That is the reported KASAN
slab-out-of-bounds read in t10_pi_verify().

Christoph suggested failing such a revalidation rather than handling the
fallout.  Do that.  Compare the new LBA data size and metadata size
against the live ones, before the queue is frozen.  If they differ while
the disk is open, return INVALID_NS/DNR.  nvme_validate_ns() turns that
into nvme_ns_remove(), as it already does for changed identifiers.

Host-initiated format and namespace management are exempt.  They arrive
through nvme_passthru_end(), where the host asked for the change.
NVME_CTRL_SELF_RESCAN marks that window.

Link: https://lore.kernel.org/linux-block/ah03bXpgFLQjOUt8@infradead.org/
Link: https://lore.kernel.org/linux-block/20260531-blk-integrity-fix-v1-1-cc7084f42cf1@outlook.com/
Found by FuzzNvme.

Signed-off-by: Chao Shi <coshi036@gmail.com>
@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144288=>linus-master branch from 1c1da3b to 4ed3bfb Compare September 9, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

linus-master new V1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ChaoShi001