Skip to content

blk-cgroup: fix lost wakeup in blkg_destroy_all() - #1122

Closed
blktests-ci-kpd[bot] wants to merge 2 commits into
linus-master_basefrom
series/1144043=>linus-master
Closed

blk-cgroup: fix lost wakeup in blkg_destroy_all()#1122
blktests-ci-kpd[bot] wants to merge 2 commits into
linus-master_basefrom
series/1144043=>linus-master

Conversation

@blktests-ci-kpd

@blktests-ci-kpd blktests-ci-kpd Bot commented Aug 11, 2026

Copy link
Copy Markdown

Pull request for series with
subject: blk-cgroup: fix lost wakeup in blkg_destroy_all()
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1144043

@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 11, 2026

Copy link
Copy Markdown
Author

Upstream branch: d58772d
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144043
version: 1

@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 12, 2026

Copy link
Copy Markdown
Author

Upstream branch: f5bbbfe
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144043
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from 206dca5 to 7c58a0f Compare August 12, 2026 13:53
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 12, 2026

Copy link
Copy Markdown
Author

Upstream branch: 3d6d817
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144043
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from 7c58a0f to d7a3d7b Compare August 12, 2026 19:40
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 13, 2026

Copy link
Copy Markdown
Author

Upstream branch: 3aa1dca
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144043
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from d7a3d7b to 02577f0 Compare August 13, 2026 19:55
@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the linus-master_base branch 2 times, most recently from d89ab11 to fdba928 Compare August 16, 2026 18:34
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 16, 2026

Copy link
Copy Markdown
Author

Upstream branch: fd923b3
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144043
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from 02577f0 to d685e46 Compare August 16, 2026 19:56
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 8d3ae59
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144043
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from d685e46 to 0210de8 Compare August 17, 2026 16:43
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Upstream branch: bd5f485
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144043
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from 0210de8 to 0ef966b Compare August 19, 2026 05:57
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 25, 2026

Copy link
Copy Markdown
Author

Upstream branch: 66498c7
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144043
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from 0ef966b to e551be9 Compare August 25, 2026 03:55
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 26, 2026

Copy link
Copy Markdown
Author

Upstream branch: 502d457
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144043
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from e551be9 to e3d58c0 Compare August 26, 2026 21:14
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 29, 2026

Copy link
Copy Markdown
Author

Upstream branch: cf72cbb
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144043
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from e3d58c0 to 7664cb2 Compare August 29, 2026 07:13
@blktests-ci-kpd

blktests-ci-kpd Bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Upstream branch: cee9395
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144043
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from 7664cb2 to c66a552 Compare August 31, 2026 10:58
@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 2, 2026

Copy link
Copy Markdown
Author

Upstream branch: 89a3129
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144043
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from c66a552 to 19eb833 Compare September 2, 2026 09:32
@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 4, 2026

Copy link
Copy Markdown
Author

Upstream branch: bc35965
series: https://patchwork.kernel.org/project/linux-block/list/?series=1144043
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from 19eb833 to a36fa87 Compare September 4, 2026 06:46
@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 7, 2026

Copy link
Copy Markdown
Author

Upstream branch: df29080
series: https://patchwork.kernel.org/series/1144043/
version: 1

Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/series/1144043/
error message:

Cmd('git') failed due to: exit code(128)
  cmdline: git am --3way
  stdout: 'Patch is empty.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To record the empty patch as an empty commit, run "git am --allow-empty".
To restore the original branch and stop patching, run "git am --abort".'

conflict:

@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 8, 2026

Copy link
Copy Markdown
Author

Upstream branch: 28924df
series: https://patchwork.kernel.org/series/1144043/
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from a36fa87 to 7d56ead Compare September 8, 2026 16:34
@kmehltretter82 kernel-patches-daemon
blk-cgroup: fix lost wakeup in blkg_destroy_all()
16ececc 
wake_up_var() requires a full barrier between making the wait condition
true and its lockless waitqueue check. spin_unlock_irq() has only
release semantics, so it does not order q->root_blkg = NULL against
that check.

During disk rebind, blkcg_init_disk() can therefore miss the wakeup and
sleep indefinitely. Add the required smp_mb(). Also mark the store with
WRITE_ONCE() since the waiter reads root_blkg locklessly with
READ_ONCE(). An LKMM model permits the missed-wakeup outcome without
the barrier and forbids it with the barrier.

Fixes: 3dbaacf ("blk-cgroup: wait for blkcg cleanup before initializing new disk")
Cc: stable@vger.kernel.org
Assisted-by: Claude:claude-fable-5
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 9, 2026

Copy link
Copy Markdown
Author

Upstream branch: 893e117
series: https://patchwork.kernel.org/series/1144043/
version: 1

@blktests-ci-kpd
blktests-ci-kpd Bot force-pushed the series/1144043=>linus-master branch from 7d56ead to 16ececc Compare September 9, 2026 08:29
@blktests-ci-kpd

blktests-ci-kpd Bot commented Sep 10, 2026

Copy link
Copy Markdown
Author

At least one diff in series https://patchwork.kernel.org/series/1144043/ irrelevant now for [{'archived': False, 'project': 241}] search patterns

@blktests-ci-kpd blktests-ci-kpd Bot closed this Sep 10, 2026
@blktests-ci-kpd
blktests-ci-kpd Bot deleted the series/1144043=>linus-master branch September 12, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

linus-master new V1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kmehltretter82