Skip to content

blk-throttle: reject IOPS limits above UINT_MAX for legacy interface - #164

Open
blktests-ci-block-trial[bot] wants to merge 2 commits into
master_basefrom
series/789=>master
Open

blktests-ci-block-trial[bot] wants to merge 2 commits into
master_basefrom
series/789=>master

Conversation

@blktests-ci-block-trial

Copy link
Copy Markdown

Pull request for series with
subject: blk-throttle: reject IOPS limits above UINT_MAX for legacy interface
version: 1
url: http://redsun45:8000/project/linux-block/list/?series=789

@blktests-ci-block-trial

Copy link
Copy Markdown
Author

Upstream branch: 940de59
series: http://redsun45:8000/project/linux-block/list/?series=789
version: 1

@blktests-ci-block-trial

Copy link
Copy Markdown
Author

Upstream branch: 841e384
series: http://redsun45:8000/project/linux-block/list/?series=789
version: 1

tg_set_conf(), used for blkio.throttle.{read,write}_iops_device legacy
blkio cgroup sysfs knobs, parses limits as u64 but stores them in
unsigned int, silently truncating values above UINT_MAX. In addition
to being an obvios correctness issue, this may result in division by
zero in tg_within_iops_limit(), if the value is truncated to zero.

Reject such values with -EINVAL and explicitly use UINT_MAX as
a sentinel value for IOPS limits.

Fixes: 3a8b31d ("blkcg: restructure blkio_group configruation setting")
Cc: stable@vger.kernel.org
Signed-off-by: Mikhail Rudenko <xyzzy@yandex-team.ru>
@blktests-ci-block-trial

Copy link
Copy Markdown
Author

Upstream branch: a500db7
series: http://redsun45:8000/project/linux-block/list/?series=789
version: 1

@blktests-ci-block-trial
blktests-ci-block-trial Bot force-pushed the master_base branch 11 times, most recently from 35db34c to da618a0 Compare September 18, 2026 23:12
@blktests-ci-block-trial
blktests-ci-block-trial Bot force-pushed the master_base branch 4 times, most recently from 107c7ec to d965859 Compare September 20, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant