Test multipath and marginal ports - #264
Open
Mr-Bossman wants to merge 2 commits into
Open
Mr-Bossman wants to merge 2 commits into
Mr-Bossman wants to merge 2 commits into
Conversation
Mr-Bossman
force-pushed
the
dev/jesse/fpin
branch
3 times, most recently
from
August 19, 2026 20:00
1d6d5a8 to
1efc76b
Compare
Contributor
Author
|
Latest version on lore is here: |
Adds functionality to set up a NVME port in marginal state. This is useful for testing the behavior of the NVME driver when a port is in a marginal state. Signed-off-by: Jesse Taube <jtaubepe@redhat.com> Reviewed-by: John Meneghini <jmeneghi@redhat.com> Tested-by: John Meneghini <jmeneghi@redhat.com> --- V1 -> V2: - Added john's review and test-by tags - Use != instead of ! == - Wrap lines over 80col V2 -> V3: - No change
Add tests/nvme/070 to test various multipath and marginal port
scenarios, while confirming the port useage and state. This test is
intended to emulate receiving an FPIN event in a multipath environment.
Co-authored-by: John Menehgini <jmeneghi@redhat.com>
Signed-off-by: Jesse Taube <jtaubepe@redhat.com>
Signed-off-by: John Meneghini <jmeneghi@redhat.com>
Tested-by: John Meneghini <jmeneghi@redhat.com>
---
V1 -> V2:
- Add John's tags
- Add _rport_check_use_opt
- Add _rport_is_not_in_use to allow for checking with a timeout
- Add _rport_num_in_use - Wrap lines over 80col
- Add timeout functionality to _rport_is_marginal, is_online,
in_use.
- Fix path state setup to have one optimized and one non-optimized port
for each host
- Fix test_set_all_marginal to correctly check non-numa iopolicy
- Remove _rport_check_opt as it was redundant
- Rename _rport_optimized to _rport_is_optimized
- Skip test if /sys/class/fcloop/ctl/set_marginal_rport does not exist
- Use grep --quiet instead of grep -q
- Use local -a for arrays
V2 -> V3:
- Add tests for inaccessable paths
- Fix fio not exiting
- Move generic code to common/nvme
Mr-Bossman
force-pushed
the
dev/jesse/fpin
branch
from
August 28, 2026 15:20
1efc76b to
cda0df4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests/nvme/070 to test various multipath and marginal port
scenarios, while confirming the port usage and state. This test is
intended to emulate receiving an FPIN event in a multipath environment.
Lore link: https://lore.kernel.org/linux-nvme/20260812174503.3705830-1-jtaubepe@redhat.com/