fix(cursor): expose Grok 4.6 xhigh Fast - #1615
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughCursor support now includes Grok 4.6 regular and Fast models, the ChangesCursor Grok model support
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to This localized change exposes Cursor Grok 4.6 xhigh options while preserving the existing Fast request contract, with the reported focused, full-suite, typecheck, lint, documentation, and privacy checks passing; no actionable merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant Client
participant CursorDiscovery
participant CursorEffortMap
participant CursorRequestBuilder
Client->>CursorDiscovery: discover Grok 4.6 variants
CursorDiscovery->>CursorEffortMap: map effort suffixes
CursorEffortMap-->>CursorDiscovery: return supported effort tiers
Client->>CursorRequestBuilder: select Grok 4.6 Fast
CursorRequestBuilder->>CursorRequestBuilder: set base model, effort, fast=true, requested_model
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ READY
Review readiness checklist
✅ 4/4 boxes ticked. This pull request is already Ready for Review. |
|
Tip For best results, initiate chat on the files or code changes.
I am replying to the latest status only. Earlier comment context is unavailable. 🧠 Learnings usedYou are interacting with an AI system. |
|
🧠 Learnings used
|
|
Thanks for following up with this Cursor-only version. This addresses the main concern I had on #1578: the Fast xhigh behavior now has both live evidence and a regression that pins the actual wire contract (grok-4.6 + effort=xhigh + fast=true) instead of relying on the flattened discovery slug. The scope also looks right now: Grok 4.5 stays capped at high, only Cursor Grok 4.6 gains xhigh, and the already-landed xAI work remains separate. I don’t see a code blocker here. Please rebase onto latest dev and let the repository CI actually run on the rebased head. One small non-blocking improvement would be to add an explicit no-effort assertion for both regular and Fast Grok 4.6, so the fallback/default behavior stays intentional if the ladder changes again. After rebase + green CI, this looks good to merge. |
|
Tip For best results, initiate chat on the files or code changes.
This head SHA was already reviewed. No additional incremental review is available until the PR receives a new commit. 🧠 Learnings usedYou are interacting with an AI system. |
|
I reviewed the full diff, the Cursor request-builder and protobuf encoder paths, the discovery callers, the tests, the documentation updates, and the existing review discussion. The implementation is appropriately scoped. I agree with the prior maintainer review: this needs a rebase and real CI before merge. The PR is still draft and its head is 35 commits behind current A non-blocking follow-up: an explicit no-reasoning assertion for both Grok 4.6 rows would keep their default-to-top-tier behavior intentional if the ladder changes later. DISPOSITION: NEEDS-CHANGE |
efe7f44 to
b9568aa
Compare
|
Tip For best results, initiate chat on the files or code changes.
This head SHA was already reviewed. No additional incremental review is available until the pull request receives a new commit. 🧠 Learnings usedYou are interacting with an AI system. |
|
🧠 Learnings used
|
|
Tip For best results, initiate chat on the files or code changes.
🧠 Learnings usedYou are interacting with an AI system. |
|
Rebased onto the latest I also added the suggested explicit no-effort assertions for both regular and Fast Grok 4.6, pinning the defaults to Validation on the rebased head:
The PR is ready for review again. Cross-platform CI and React Doctor are currently awaiting maintainer approval to run on the forked head. |
|
🧠 Learnings used
|
|
Thanks for the follow-up and for tightening this up after review. This is useful because Cursor's Grok 4.6 support now matches the actual live lineup instead of silently stopping at CI is green on the rebased head, so I merged this. Thanks for the contribution. |
Summary
low/medium/high/xhighladder for both regular and Fast picker rowsgrok-4.6with separateeffort=xhighandfast=truerequested_modelparametersThis is the Cursor-only follow-up requested when #1591 was closed as superseded. The direct xAI catalog half has already landed in #1593; this PR does not modify
src/providers/registry.tsor any xAI routing behavior.Root cause
The Cursor Grok 4.6 fallback rows were added by mirroring Grok 4.5's three-tier ladder before Cursor exposed its final lineup. Cursor now advertises
cursor-grok-4.6-xhighandcursor-grok-4.6-xhigh-fast, but OpenCodex still capped both rows athigh. That hid Extra High from the picker and clamped explicitxhighrequests.Fast requests remain parameterized rather than sending the flattened discovery slug:
grok-4.6pluseffort=xhighandfast=true. The flattenedcursor-grok-4.6-xhigh-fastid is availability evidence only.Verification
cursor-grok-4.6-xhighandcursor-grok-4.6-xhigh-fastgrok-4.6[effort=xhigh,fast=true]completed successfullygit diff --check— passedChecklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit
New Features
xhighreasoning tier for Grok 4.6.Documentation
Tests