WIP: Switch learndaxa to FetchContent (using CPM)#8
Closed
deccer wants to merge 5 commits into
Closed
Conversation
Author
|
Daxa requires a little fix before this PR can be merged |
deccer
changed the title
Member
There was a problem hiding this comment.
This should also be put into the docs repo since its replaced in the first chapter of the tutorial
Author
There was a problem hiding this comment.
Yep, i have something lined up already, just not PRed yet
FabulousCodingFox
marked this pull request as draft
January 10, 2026 23:04
FabulousCodingFox
marked this pull request as ready for review
January 30, 2026 12:38
Author
|
no longer interested. maybe when the endless refactor ends "next month". |
Contributor
|
If this is in reference to the task graph refactor Patrick and Saky were working on back in January (which was the only time I could find any mention of a "next month"), I believe that was completed months ago |
|
The refactor was done mid march |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and removed all the vcpkg remains and I cleaned up CMakePresets a little bit