feat(symbols): add symbols upload command for React Native + Android symbols#745
feat(symbols): add symbols upload command for React Native + Android symbols#745abelonogov-ld wants to merge 2 commits into
symbols upload command for React Native + Android symbols#745Conversation
Align the identifier naming with the `symbols upload` command and the `_sym/.../id/` storage layout: `--build-id` -> `--symbols-id`, the `*.buildid` sidecar -> `*.symbolsid`, and the internal prefixes/helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 5 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 575591b. Configure here.
| } | ||
|
|
||
| if !d.IsDir() && isSourceMapUploadFile(filePath) { | ||
| if !d.IsDir() && (strings.HasSuffix(filePath, ".js.map") || strings.HasSuffix(filePath, ".js")) { |
There was a problem hiding this comment.
Sourcemaps skip RN silently
High Severity
sourcemaps upload now only collects *.js and *.js.map, so React Native *.jsbundle / *.bundle artifacts in the same tree are ignored while the command still succeeds after uploading web files only.
Triggered by learned rule: Breaking CLI default changes require transitional stderr warnings
Reviewed by Cursor Bugbot for commit 575591b. Configure here.
| // the version+basePath scheme. The key becomes <prefix>/<symbolsID>/<basename> | ||
| // so it matches the key the backend derives from the reported symbols id. | ||
| if symbolsID != "" { | ||
| return fmt.Sprintf("%s/%s/%s", symbolsIDPrefix, symbolsID, filepath.Base(fileName)) |
There was a problem hiding this comment.
Android mapping keys collide
High Severity
With --symbols-id (or a sidecar), every discovered mapping.txt is keyed as _sym/android/id/<id>/mapping.txt, so multiple mappings under one --path overwrite the same object regardless of relative directory.
Reviewed by Cursor Bugbot for commit 575591b. Configure here.
| } | ||
| return nil | ||
| }) | ||
| return found |
There was a problem hiding this comment.
First sidecar id reused
High Severity
When --symbols-id is omitted, readSymbolsIDSidecar stops at the first non-empty *.symbolsid under --path and that single id is applied to every uploaded artifact in the batch.
Reviewed by Cursor Bugbot for commit 575591b. Configure here.
| Path: path, | ||
| Name: filepath.Base(path), | ||
| }) | ||
| return files, nil |
There was a problem hiding this comment.
Single file type unchecked
Medium Severity
If --path points at a single file, getAllSymbolFiles adds it without calling isSymbolUploadFile, so unrelated files can be uploaded under symbol keys for the chosen --type.
Reviewed by Cursor Bugbot for commit 575591b. Configure here.
| for i, file := range files { | ||
| if err := uploadFile(file.Path, uploadUrls[i], file.Name); err != nil { | ||
| return fmt.Errorf("failed to upload file %s: %w", file.Path, err) | ||
| } |
There was a problem hiding this comment.
Upload URL count unchecked
Medium Severity
The upload loop indexes uploadUrls[i] for each file, but getSymbolUploadUrls only rejects a completely empty URL list, not a short list relative to len(files).
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 575591b. Configure here.
1 participant
Summary
ldcli symbols uploadcommand for uploading symbolication artifacts over the dedicated symbol-upload path (large files, multi-segment keys), separate fromsourcemaps upload.--type react-native(composed source maps + bundles) and--type android(R8/ProGuardmapping.txt).launchdarkly.symbols_id.htlhash) via--symbols-idor an auto-read*.symbolsidsidecar, falling back to--app-versionwhen absent. Storage layout:_sym/{js,android}/id/<symbols-id>/….Test plan
go test ./cmd/symbols/...ldcli symbols upload --type react-native --path ./build --project <key>against a local backendldcli symbols upload --type android --path ./app/build/symbols/<variant> --project <key>Made with Cursor