RTECO-2003: add the Choco project type - #1616
Open
bhanurp wants to merge 2 commits into
Open
Conversation
`jf setup choco` needs this: the whole setup family is keyed by project.ProjectType, so packageManagerToRepositoryPackageType, packageManagerConfigs and IsSupportedPackageManager all look choco up by enum value, and setupCmd resolves the CLI argument through project.FromString. Appended at the end of both the const block and ProjectTypes. The enum is index-based (ProjectTypes[projectType]), so inserting mid-list would silently renumber every later type. `jf choco` itself does not need this; it reports telemetry through ExecWithPackageManager, which takes a plain string, as nix, apt and huggingface already do. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 10, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ChocotoProjectTypeandProjectTypes, for RTECO-2003 (jf choco+jf setup choco).jf setup choconeeds it: the whole setup family is keyed byproject.ProjectType—packageManagerToRepositoryPackageType,packageManagerConfigsandIsSupportedPackageManagerall look choco up by enum value, andsetupCmdresolves the CLI argument throughproject.FromString("choco"). Without the enum entry there is no way to name choco tojf setup.jf chocoitself does not need this — it reports telemetry throughExecWithPackageManager, which takes a plain string, asnix,aptandhuggingfacealready do.Note for reviewers
Appended at the end of both the const block and
ProjectTypes, in matching positions. The enum is index-based (ProjectTypes[projectType]), so inserting mid-list would silently renumber every later type.Test plan
go build ./...go test ./common/project/...🤖 Generated with Claude Code