Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently,
@ionic/reactand@ionic/react-routerbuild with rollup and@rollup/plugin-typescript, which reports type errors as(!) [plugin typescript]warnings and still exits 0. Neitherbuild-reactnorbuild-react-routerrunstsc --noEmit, so a type error can't fail CI. This is the same gap #31320 closed for@ionic/vueand@ionic/vue-router, and it came out of review feedback on that PR asking whether the typecheck step was worth adding to the other frameworks.What is the new behavior?
Both React packages now have a
typecheckscript and a CI step that runs it between lint and build, matching the Vue packages. Neither package needed source changes: both already passtsc --noEmitclean under thestrictthey inherit fromcore/tsconfig.base.json, so this is a guard against future regressions rather than a cleanup.Angular is deliberately left alone.
ng-packagrfails the build on type errors, so a separate step there would be redundant. I added a comment tobuild-angularandbuild-angular-serversaying so, so the next person doesn't have to work it out again.Does this introduce a breaking change?
Other information
Follow-up to #31320, addressing @thetaPC's review comments