-
Notifications
You must be signed in to change notification settings - Fork 13.3k
fix(input): support floating labels with slotted content #31309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brandyscarney
wants to merge
23
commits into
major-9.0
Choose a base branch
from
FW-6471-input
base: major-9.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+431
−160
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
71a8fc3
fix(input): float label when start and end slot exist
brandyscarney 5e98726
test(input): update slot test
brandyscarney 7adbc3e
fix(input): always stop label click propagation
brandyscarney 7dddcf7
chore(): add updated snapshots
Ionitron 26c8c13
fix(input): reverse the row on input-content for end labels
brandyscarney be85bad
chore(): add updated snapshots
Ionitron 375995b
chore(): add updated snapshots
brandyscarney 7c4e480
fix(input): account for RTL and vertically center the clear input
brandyscarney f8e5be6
test(input): rename tests and add fill and rtl coverage
brandyscarney 106dfea
chore(): add updated snapshots
brandyscarney 9ef4d4b
test(input): capture slot behavior when value is not present
brandyscarney eaeada8
chore(): add updated snapshots
brandyscarney 996134f
style: lint
brandyscarney fd0557a
chore(): add updated snapshots
Ionitron 3072291
fix(input): style the right element for flex
brandyscarney 1483023
fix(input): revert icon change - we need to do it in other components…
brandyscarney cc20bbf
chore(): add updated snapshots
Ionitron 4ac30a6
style(input): remove extra label function
brandyscarney 892f6e7
docs(breaking): add a section for input structural changes
brandyscarney 921b54e
copy editing
brandyscarney 6c81728
Merge branch 'major-9.0' into FW-6471-input
brandyscarney 93e14a0
fix(input): disable the label transition when start or end slots are …
brandyscarney 9b59417
fix(input): allow click propagation for slotted content
brandyscarney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this get the same private API comment as
--highlight-color? It's sitting right next to--border-radiusand--padding-startwhich are both@propdocumented, so as it is now it looks like something people can set.Also wondering about a fallback on the
var(). Without one a missing property invalidates the wholetransform, so the label would lose itsscale()too and not just the translate.