Fix AV1 EncTools frame type with deep lookahead - #388
Open
fjdoria76 wants to merge 1 commit into
Open
Conversation
Preserve GOP-derived frame types when lookahead has not produced a valid hint. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AV1 EncTools can return
MFX_ERR_MORE_DATAwhile deep lookahead is still buffering frames. In that case, the optional pre-encode GOP hint remains zero-initialized, but was copied into the task and replaced the normal GOP-derived frame type, causingInvalid FrameType:0whenasync_depth > 1.Only apply the EncTools frame-type hint when it is nonzero, preserving normal AV1 GOP fallback behavior while retaining asynchronous lookahead support.
Validation:
git diff --checkpassed and CMake configuration succeeded. The full macOS build is blocked by missingva/va_version.hand unrelated AVX compiler configuration errors.Fixes: #370