refactor(web): stack-related service and actions#29403
Open
meesfrensel wants to merge 1 commit into
Open
Conversation
meesfrensel
force-pushed
the
refactor/stack-actions
branch
from
96b08df to
698b96d
Compare
meesfrensel
commented
Jun 30, 2026
| @@ -115,6 +116,23 @@ export class TimelineManager extends VirtualScrollManager { | |||
| this.#unsubscribes.push( | |||
| eventManager.on({ | |||
| AssetUpdate: (asset: AssetResponseDto) => this.#updateAssets([toTimelineAsset(asset)]), | |||
| StackCreate: (stack) => updateStackedAssetInTimeline(this, stack), | |||
Collaborator
Author
There was a problem hiding this comment.
Do the timeline manager event handlers need a guard with if (withStacked) or something? The scenario I'm afraid of is that stacks could appear in non-withStacked views like album timeline. However, I couldn't reproduce that case so I'm not sure it's needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the old stack-related actions to a service and new action structure. Old style callbacks are moved to events and where applicable, handled directly in the timeline manager instead of delegating to the asset viewer first.
I think I tested all flows and actions, and everything I tested works as expected.