Skip to content

Extract manufacturer and device for samsung videos#29375

Open
jonastahl wants to merge 1 commit into
immich-app:mainfrom
jonastahl:samsung-video
Open

Extract manufacturer and device for samsung videos#29375
jonastahl wants to merge 1 commit into
immich-app:mainfrom
jonastahl:samsung-video

Conversation

@jonastahl

@jonastahl jonastahl commented Jun 29, 2026

Copy link
Copy Markdown

Description

So far immich was not able to extract any device details from videos taken with a Samsung device, as mentioned in issue #20329.
I extended the metadata extractor to fall back to reading the Author tag set by Samsung and sets the manufacturer to Samsung if the tag 'Samsung Model' exists.

Does not yet fix the issue as there are still problems with other camera types.

How Has This Been Tested?

  • Videos from Samsung devices are working now
  • Photos and Videos working before are still working

Screenshots (if appropriate)

image

API Changes

no changes

Checklist:

  • I have carefully read CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

...

@immich-push-o-matic

immich-push-o-matic Bot commented Jun 29, 2026

Copy link
Copy Markdown

Label error. Requires exactly 1 of: changelog:.*. Found: 🗄️server. A maintainer will add the required label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant