fix(mobile): treat wired ethernet as unmetered on ios#29351
Open
santoshakil wants to merge 1 commit into
Open
Conversation
check the metered flags instead of the interface type, so ethernet counts like android already does.
|
📱 Android release APK (universal) — Download: https://github.com/immich-app/immich/actions/runs/28286702633/artifacts/7923738029 QR codeInstalls as a separate app (applicationId |
shenlong-tanwen
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
on ios, backup only counted wifi as unmetered. so with "upload over cellular" off and only a wired ethernet connection (usb-c adapter, or the ios app on a mac), backups got prepared but never uploaded — turning "upload over cellular" on made it work, which is the tell. now the apple side checks the path's metered flags (not cellular, not expensive, not constrained) instead of the interface type, same as android already does, so wired ethernet counts like wifi.
tested on an iphone 15 pro max with a usb-c ethernet adapter in airplane mode (wifi + cellular off, ethernet only) and "upload over cellular" off. before: backup skips everything (network capabilities come back empty, isUnmetered false). after: same setup reports unmetered and the photo uploads over ethernet and shows up on the server. wifi-only backup still behaves the same.
fixes #26493