NAS-142294 / 27.0.0-BETA.1 / fix: do not grade stale comments as MEDIUM - #12
Merged
william-gr merged 1 commit intoAug 20, 2026
Merged
Conversation
Callers fail the review check at MEDIUM and above. A comment or internal doc that disagrees with the code beside it is not an executable hole, so it is LOW. Public API/CLI/protocol/test guarantees still gate. The worked MEDIUM example is now a test that certifies the wrong walk, not a sentence in RELEASING.md. Co-authored-by: William Grzybowski <william@grzy.org>
agent-stewie
force-pushed
the
fix/comments-are-not-medium
branch
from
August 20, 2026 13:32
2d39bbc to
6efdf52
Compare
aervin
approved these changes
Aug 20, 2026
bugclerk
changed the title
Contributor
Contributor
|
This PR has been merged and conversations have been locked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Callers fail
Automatic PR reviewon any finding at MEDIUM or above. Item 2 of this rubric currently maps a comment or doc describing behaviour the code does not have to MEDIUM. Combined with “a finding that is still true still goes in the structured output,” every half-wrong code comment holds the merge.That showed up on
iXsystems/truenas-file-manageras a queue of PRs gated on stale comments, CI annotation wording, and pre-existing product behaviour a test PR merely discovered. The reviewer was following this file.The gate threshold itself (MEDIUM+) does not change. LOW comments can still be reported.
What changed
RELEASING.md.review/schema.jsonseverity description matches.Public/user-facing contracts (API, CLI, protocol, published release process) still count as item 2.
Live on merge
Callers pin this workflow at
@master, so this is live in every consumer on the next review run. That is the point.Co-authored-by: William Grzybowski william@grzy.org