Copy to clipboard: stop replacing apostrophes with backticks - #281
Merged
Conversation
setupPopover sanitised the selection with replaceAll("'", "`") before
putting it on the clipboard. That escaping is inherited from
js/share-this-clipboard.js, where it is required because the text is
interpolated into an inline onclick handler; here the text only ever
reaches clipboard.writeText() and textContent, both of which take
arbitrary strings. The substitution has no purpose in this path and
corrupts every quotation containing an apostrophe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #280.
setupPopover()sanitised the selection withreplaceAll("'", "\")before putting it on the clipboard. That escaping is inherited fromjs/share-this-clipboard.js, where it is required because the text is interpolated into an inlineonclickhandler. Here the text only ever reachesclipboard.writeText()andtextContent`, both of which take arbitrary strings — so the substitution has no purpose and corrupts every quotation containing an apostrophe.Verified by selecting text containing apostrophes and copying: the clipboard and the confirmation dialog now both carry the original characters.