fix(utils): include original cause in _LazyModule ModuleNotFoundError - #47899
Closed
Sayyam-Akram wants to merge 2 commits into
Closed
fix(utils): include original cause in _LazyModule ModuleNotFoundError#47899Sayyam-Akram wants to merge 2 commits into
Sayyam-Akram wants to merge 2 commits into
Conversation
Contributor
CI recapDashboard: View test results in Grafana |
Member
|
this is the most code agent code i've ever seen in my life and you're blocked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Fixes #47893
If an optional module like accelerate or sentencepiece is not installed in your system, and the import fails, for example when using MistralForSequenceClassification, then
_LazyModule.__getattr__will catch the underlying ModuleNotFoundError and raise a generic error message. This obscures what is really needed from the user.This PR enhances the
_LazyModule.__getattr__function with the original exception information (Caused by: {e}). This provides instant, unmistakable diagnostic information of what package is missing.I've also written a unit test in tests/utils/test_import_utils.py to make sure that exception causes are preserved.
Code Agent Policy
Before submitting
Who can review?