Fix GPT-2 FlashAttention mask preparation without pipeline - #6434
Draft
sdjasj wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tp_size=1,pp_size=1,enable_all_optimization=Trueconfiguration to the GPT-2 regression matrixWhy
For a non-pipeline, non-sequence-parallel GPT-2 model, the policy replaced
GPT2Attention.forwardwith the ColoAttention implementation but left the Hugging FaceGPT2Model.forwardunchanged. Hugging Face passed its additive attention-mask Tensor directly to the replacement, which attempted**attention_maskand raised a TypeError because the value was not a mapping.The existing ColossalAI GPT-2 model forward already converts masks into the keyword dictionary expected by ColoAttention and preserves causal-mask behavior.
Impact
GPT-2 works with
HybridParallelPlugin(enable_all_optimization=True)when TP, PP, and SP sizes are all one.Fixes #6389.
Validation
compileallandgit diff --check: passed