HIP author skill - #438
Conversation
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
9dd221f to
13c42a8
Compare
13c42a8 to
5545c86
Compare
There was a problem hiding this comment.
a few thoughts:
- H4HIP as outlined in https://github.com/helm/community/blob/main/hips/hip-0012.md is missing from this
- rather than targeted word length for each section, is it better to have instructions that focus more on the spirit of the goal - such as "keep proposals as simple as possible. do not add unnecessary detail other than what's needed" etc?
- meta question - what is this ultimately adding for an LLM above what a copy of https://github.com/helm/community/blob/main/hips/hip-0001.md would provide? If there are missing pieces from hip 001 (eg, H4HIP defined in 0012) should we instead amend hip 0001 with any new/missing/clarifying information?
Signed-off-by: George Jenkins <gjenkins8@bloomberg.net>
Also to be discussed: the HIP frontmatter actually already has a Finally, H4HIP was simply a thing we prepended to the HIP's PR title. So we can keep doing that with e.g.
Given LLMs tendency to write overly verbosely, "as simple as possible" are much more ambiguous. In fact, when I updated the skill to remove the word counts and add such language, the eval reported:
That said, an update to the skill to use the word counts as guides (not targets, and not hard ceilings) helped a little in evaluations: e.g. 746af84#diff-61b24769e609a18d3995dcd65eecd2cc83143d97c8b2faee5c4637b8e6f37069R74
The "template" is included inline with the skill so it can be enriched with more detailed instructions. So yes, these could (perhaps should) be fed back into the original template - any instructions should be applicable to both people and LLMs after all. But I have purposefully inlined into the skill initially, in order to get the skill created without affecting existing process. It is hard enough as it is to get changes into this repo as is without proposing changes to existing HIPs! |
|
| @@ -0,0 +1,176 @@ | |||
| --- | |||
There was a problem hiding this comment.
apart from questions in the PR comments, a quick note about file location - does Claude support .agents directory? I had been following this more in previous months, and so far don't see this in the docs, but do see issues like this: anthropics/claude-code#31005
There was a problem hiding this comment.
Claude doesn't (directly) support .agents/ to my understanding, and I think we also want to remain vendor agnostic.
(personally, I have a startup hook for Claude that symlinks e.g. CLAUDE.md -> AGENTS.md)
There was a problem hiding this comment.
Right, I was asking because that's what the folder is named. But that's fine, see my approval comment below. We can iterate however needed to improve the skill to help users.
scottrigby
left a comment
There was a problem hiding this comment.
Thanks @gjenkins8 and @sabre1041 for the discussion in today's dev call. I think we reached a good point of agreement.
My main concern wasn't with agent skills themselves, but that this largely duplicates HIP 0001 with some additional instructions. And if those instructions are improvements to the general HIP authoring process, they should ultimately be proposed as amendments to HIP 0001 rather than allowing the two to drift.
But it sounds like we're aligned on that. The skill is tooling for AI harnesses and is expected to evolve quickly. It's there to help, not to redefine the HIP process. HIP 0001 remains the source of truth.
That also gives us flexibility to iterate on the skills independently, including moving them to a dedicated repository in the future if that makes sense, without creating ambiguity about where the canonical guidance lives.
With that understanding, I'm comfortable treating the skill as an iterative helper while ensuring generally applicable guidance eventually flows back into HIP 0001.
First pass at a HIP authoring skill:
The HIP template is duplicated and embedded in the skill - enables providing much more detailed guidance for the sections than what is currently in
HIP-0001closes: #436