fix(telegram-bot): point the postgres-real suite at the CockroachDB port CI uses - #11009
Open
clayrisser wants to merge 1 commit into
Open
fix(telegram-bot): point the postgres-real suite at the CockroachDB port CI uses#11009clayrisser wants to merge 1 commit into
clayrisser wants to merge 1 commit into
Conversation
…I uses
tests/docker-compose.yaml publishes CockroachDB on host port 26258
('26258:26257'), and server/account's postgres-real suite defaults to
26258 accordingly. services/telegram-bot's postgres-real suite defaults
to 26257, so running it locally against the documented compose stack
fails in beforeEach with ECONNREFUSED. CI hides this because the workflow
exports DB_URL with 26258 for both.
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Clay Risser <clayrisser@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
clayrisser
force-pushed
the
fix/telegram-bot-cockroach-test-port
branch
from
August 13, 2026 06:47
557500a to
a76eae3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
services/telegram-bot/pod-telegram-bot/src/__tests__/postgres-real.test.ts:49defaults CockroachDB to host port 26257:Everything else in the repository says 26258. All four test compose files publish CockroachDB there:
and the sibling
postgres-realsuite agrees:as does CI:
26257is CockroachDB's container port;26258is the host port the compose files map it to. The telegram-bot suite is the lone reference to the container port from the host side.Consequence: bring up the documented compose stack and run
rush testlocally, and the telegram-botpostgres-realsuite fails inbeforeEachwithECONNREFUSEDwhileserver/account's identical suite passes. CI never sees it, because the workflow exportsDB_URLand the default is not used.Fix
One character.
Scope and residual risk
DB_URLstill wins where it is set, so CI behaviour is unchanged.dev/docker-compose.yamldoes use26257, but that is the dev stack on a different CockroachDB image line, not a test stack, and nopostgres-realsuite points at it.Verification
Read out of
develop@1be6047c8: eight references to26258(four composes, twopostgres-realdefaults, the CI export, andfoundations) against this one26257.git applyis clean.I have not run the suite against a live CockroachDB — it needs the compose stack up, and the change is to a default string that is only reached when
DB_URLis unset. The claim here is the consistency argument above rather than a measured pass.