Fix installation under Pyodide 314 (matplotlib 3.10) - #1109
Merged
Conversation
Matplotlib 3.10 requires numeric line-spacing values. Convert `normal` to its equivalent default, 1.2, so themes render on both supported Matplotlib versions.
Matplotlib 3.10 raised `StopIteration` when setting secondary-axis ticks or limits because it could not resolve the axis name. Panels now expose both primary and secondary axes through Matplotlib's name lookup.
Pyodide supplies Matplotlib 3.10.8 and statsmodels 0.14.6 as platform packages. plotnine's previous requirements excluded both versions. Allow Matplotlib 3.10 and require statsmodels 0.14.6 on every platform. Tests continue to require Matplotlib 3.11 or later because the existing baseline images use Matplotlib 3.11 text metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR drops the lower bound for matplotlib 3.10 so that plotnine 0.16+ can be installed on under Pyodide.
fixes #1106