Test align_bounds throwing assert when realizing into pre-allocated buffer - #9373
Open
mcourteaux wants to merge 3 commits into
Open
Test align_bounds throwing assert when realizing into pre-allocated buffer#9373mcourteaux wants to merge 3 commits into
mcourteaux wants to merge 3 commits into
Conversation
…uffer. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9373 +/- ##
==========================================
- Coverage 70.08% 70.00% -0.08%
==========================================
Files 259 260 +1
Lines 79158 79287 +129
Branches 19293 19327 +34
==========================================
+ Hits 55477 55504 +27
- Misses 17886 17913 +27
- Partials 5795 5870 +75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| printf("%d: Expected an error due to align_bounds being " | ||
| "violated by the output buffer's min/extent, but the " | ||
| "pipeline ran and traced bounds [%d, %d)\n", | ||
| __LINE__, trace_min, trace_min + trace_extent); |
Member
There was a problem hiding this comment.
Why print the line number in the test file here?
Contributor
Author
There was a problem hiding this comment.
Because that happens in all the other tests above too. Useful for debugging when it trips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just add a test that I felt like was relevant. Created with Claude during my work on #9357.
Checklist