chore(parallel tests): revamp parallel test outputs for searchability and clarity - #17940
chore(parallel tests): revamp parallel test outputs for searchability and clarity#17940chalmerlowe wants to merge 8 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request revamps the parallelization output in the Kokoro system test script, renaming 'passed' packages to 'succeeded' and adding detailed log outputs for succeeded packages. It also introduces temporary configurations and a dummy test in google-cloud-dns to verify mixed test results. Feedback on these changes suggests removing the temporary experimental configurations and dummy test before merging. Additionally, it is recommended to avoid printing detailed logs for succeeded packages to prevent excessively large and noisy CI/CD build logs, opting instead to list only their names.
|
|
daniel-sanche
left a comment
There was a problem hiding this comment.
LGTM, after trigger comments are removed
There was a problem hiding this comment.
Removing trigger comments. Reckon I am gonna leave this unmerged until Monday since this has a broad ranging the can impact troubleshooting, debugging. Would like to be there when this first starts being used broadly to handle any unforeseen issues.
Warning
setup.pyfiles and the dummy test ingoogle-cloud-dnsare only for verification and will be reverted before this PR is merged, hence thedo-not-mergelabel.Problem
The current parallel system test output can be difficult to read and search, especially when dealing with many packages or mixed results (where some test sessions pass and others fail). Logs for successful packages were often hidden, and searching for specific package results required scanning through large blocks of text.
Solution
This PR revamps the output format of parallel system tests to improve readability and searchability (CTRL+F).
Specific Changes
@SUMMARY,@FAILED,@SUCCEEDED,@PACKAGE) for quick navigation (i.e. viaCTRL+F) to key sections of the logs.Configuring environment...).@FAILEDsection to ensure visibility, with clear labels indicating which session(s) need attention.Note
google-cloud-dns,google-cloud-translate,google-cloud-speech,google-cloud-access-approval) to demonstrate the new layout and verify handling of mixed results.system.sh: The core of this PR is the changes to.kokoro/system.sh.🔍 Search Cheat Sheet for Reviewers
@SUMMARY@FAILED@SUCCEEDED<package-name>@PACKAGE (FAILED): <package-name>