Skip to content

feat(rest): add PQC curves to REST client #16233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hongalex wants to merge 2 commits into from
+4 −0
Closed

feat(rest): add PQC curves to REST client #16233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02fc095
feat(rest): add PQC curves to REST client
hongalex Jul 2, 2026
9f7838f
Merge branch 'main' into feat-support-pqc
hongalex Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions google/cloud/internal/curl_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,10 @@ Status CurlImpl::MakeRequestImpl(RestContext& context) {
if (!status.ok()) return OnTransferError(context, std::move(status));
handle_.SetSocketCallback(socket_options_);
if (!status.ok()) return OnTransferError(context, std::move(status));
status = handle_.SetOption(CURLOPT_SSL_EC_CURVES, "X25519MLKEM768:X25519:P-256:P-384");
if (!status.ok()) {
GCP_LOG(INFO) << "CURLOPT_SSL_EC_CURVES failed: " << status;
}
Comment on lines +604 to +607

@gemini-code-assist gemini-code-assist Bot Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Reusing the status variable for an option whose failure is explicitly ignored is risky. If CURLOPT_SSL_EC_CURVES fails, status is left in a non-OK state until it is overwritten by the next SetOption call. If the code is refactored, reordered, or if another check is inserted in between, this temporary error state could be accidentally propagated or returned.

Using a separate local variable (e.g., ec_status) avoids polluting the main status variable and makes the intent to ignore the failure much clearer and safer.

  auto ec_status = handle_.SetOption(CURLOPT_SSL_EC_CURVES, "X25519MLKEM768:X25519:P-256:P-384");
  if (!ec_status.ok()) {
    GCP_LOG(INFO) << "CURLOPT_SSL_EC_CURVES failed: " << ec_status;
  }
References
  1. Prefer defensive code, such as explicit ok() checks, even if they seem redundant based on the current implementation of a framework, as the framework's contract may change in the future.

status = handle_.SetOption(CURLOPT_NOSIGNAL, 1);
if (!status.ok()) return OnTransferError(context, std::move(status));
status = handle_.SetOption(CURLOPT_TCP_KEEPALIVE, 1L);
Expand Down
Loading