[Android] Refine bad build check and testcase manager execution - #5456
Open
IvanBM18 wants to merge 3 commits into
Open
[Android] Refine bad build check and testcase manager execution#5456IvanBM18 wants to merge 3 commits into
IvanBM18 wants to merge 3 commits into
Conversation
IvanBM18
force-pushed
the
feature/android-bad-build-check
branch
from
September 3, 2026 20:59
6c51bd7 to
455c3f5
Compare
IvanBM18
force-pushed
the
feature/android-bad-build-check
branch
from
September 3, 2026 21:13
455c3f5 to
c41d97d
Compare
IvanBM18
force-pushed
the
feature/android-bad-build-check
branch
from
September 3, 2026 21:20
c41d97d to
91f145b
Compare
IvanBM18
force-pushed
the
feature/android-bad-build-check
branch
from
September 3, 2026 21:26
91f145b to
8630786
Compare
IvanBM18
force-pushed
the
feature/android-bad-build-check
branch
from
September 3, 2026 21:50
8630786 to
7ea0de9
Compare
Xeicker
requested changes
Sep 4, 2026
IvanBM18
force-pushed
the
feature/android-bad-build-check
branch
from
September 4, 2026 17:53
29bb199 to
a9b0c46
Compare
Xeicker
approved these changes
Sep 4, 2026
IvanBM18
force-pushed
the
feature/android-bad-build-check
branch
from
September 4, 2026 22:30
a9b0c46 to
0e01fdf
Compare
dylanjew
reviewed
Sep 8, 2026
dylanjew
left a comment
dylanjew
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. sorry, forgot to send my comments earlier
| app_directory = environment.get_value('APP_DIR') | ||
| environment.set_value('PIDS', '[]') | ||
|
|
||
| logs.info( |
Collaborator
There was a problem hiding this comment.
are these useful or are they more debug logs?
Comment on lines
1295
to
1298
| # 1. Need to account for startup crashes with no crash state. E.g. failed to | ||
| # load shared library. So, ignore state for comparison. | ||
| # 2. Ignore leaks as they don't block a build from reporting regular crashes | ||
| # and also don't impact regression range calculations. |
Collaborator
There was a problem hiding this comment.
could you move this comment back to the code it describes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: b/553141628
Overview
Since Android API level 30 (and apps targeting Android 11+), apps have scoped storage access. Previously, bad build checks for Android did not verify whether the application process actually survived startup because
am startreturns 0 even if the process dies immediately.This PR enhances
check_for_bad_build()intestcase_manager.pyby ensuring command line files are written prior to execution and flipping a conditional so in the bad build check the android specific validation proceeds other validations.The later was required because thanks to this PR we added the possibility to check for false positives, but this added a problem in which valid builds were incorrectly flagged as crashes, so by flipping the conditional we fix this.
Changes
src/clusterfuzz/_internal/bot/testcase_manager.py: Updatedcheck_for_bad_build()to passwrite_command_line_file=Trueand verify target application process presence on Android post-launch.Tests performed
When this happen now CF correctly determines that the app crashed due to runtime issues not related to memory errors.
PR stack
masterfeature/android-exit-code-constantsfeature/android-exit-code-corefeature/android-exit-code-process-handlerfeature/android-bad-build-check👈Note:
Adding additional debug logs in this other PR: