Download expat as an archive and make it an isolated bazel module - #3176
Open
Databean wants to merge 3 commits into
Open
Download expat as an archive and make it an isolated bazel module#3176Databean wants to merge 3 commits into
Databean wants to merge 3 commits into
Conversation
This is recommended by bazel: https://bazel.build/rules/lib/repo/git > Prefer http_archive to git_repository. Bug: b/559825860
It can no longer depend on build targets from the root module, and has an isolated build. The root module and other modules can still depend on it. This is a step on the way to isolating the crosvm build, so its custom rust configuration doesn't affect the root module. It is part of the dependency chain of crosvm -> wayland -> expat. Bug: b/559825860
Bug: b/559825860
Databean
force-pushed
the
expat_module
branch
from
September 12, 2026 01:26
f613a56 to
e544785
Compare
jmacnak
approved these changes
Sep 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using http over git is recommended by bazel: https://bazel.build/rules/lib/repo/git
It can no longer depend on build targets from the root module, and has an isolated build. The root module and other modules can still depend on it.
This is a step on the way to isolating the crosvm build, so its custom rust configuration doesn't affect the root module. It is part of the dependency chain of crosvm -> wayland -> expat.
Bug: b/559825860