fix: handle Windows paths in adk eval#6419
Open
sgoel2be24-cyber wants to merge 2 commits into
Open
Conversation
Author
|
Thanks for updating the branch with the latest I checked the resulting CI failures. All unit-test jobs fail on the same unrelated Antigravity test, Current upstream On the updated PR head, the contribution-specific checks still pass:
The triage-agent failure also appears transient because Gemini returned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
and duplicate-merging behavior
Fixes #6415
Root cause
parse_and_get_evals_to_run()treated the colon in a Windows drive prefixsuch as
C:\as the eval-case selector separator. This reduced the eval-setpath to
Cand discarded selectors appearing after a later colon.Testing
9 passed— focused parser regression cases1 passed— existingtest_cli_eval_with_eval_set_file_pathregression11 passed— complete parser test module42 passed— adjacent CLI test modulegit diff --checkpassedThe complete repository suite was not rerun because the native Windows
baseline contains known unrelated platform failures.
Two aggregate pre-commit hooks use POSIX executable/shebang paths that native
Windows could not launch directly. Their underlying checks passed through the
repository’s available Git Bash and uv routes; no hook configuration was
changed.
Scope
The change is limited to the eval-set parser and focused unit tests. It does
not depend on filesystem existence and does not change evaluation execution,
result storage, or CLI syntax.