Skip to content

Update include_plugins per Issue #1173 - 9 - #1990

Merged
zyantw merged 6 commits into
mainfrom
zyantw-patch-7
Jul 28, 2026
Merged

Update include_plugins per Issue #1173 - 9#1990
zyantw merged 6 commits into
mainfrom
zyantw-patch-7

Conversation

@zyantw

@zyantw zyantw commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Rendered page> https://deploy-preview-1990--adk-docs-preview.netlify.app/tools-custom/function-tools/#control-plugin-inheritance
PRs> #1190 #1192
Original Issue> #1173
Originating code commit: google/adk-python@777dba3

The code snippet broke the first time so I worked on several commits to fix it. The rendering looks good now!


  • Changed the proposed note format into a bullet point, then into a subsection to not break the snippets.
  • Made the explanation shorter and more direct so it matches Google's writing style guide.
  • Fixed and replaced the undefined agent variable with a concrete MyImageAgent placeholder class to make the Python snippet self-contained.
  • Added comments inside the code to explain exactly what happens when you turn plugins on or off (like how it affects things like tracing and events).
  • Did light formatting in the rest of the page

Rendered page>
PRs> #1190  #1192 
Original Issue> #1173 

- Changed the proposed note format into a bullet point.
- Made the explanation shorter and more direct so it matches Google's writing style guide.
- Fixed and replaced the undefined agent variable with a concrete MyImageAgent placeholder class to make the Python snippet self-contained.
- Added comments inside the code to explain exactly what happens when you turn plugins on or off (like how it affects things like tracing and events).
- Did light formatting in the rest of the page
@netlify

netlify Bot commented Jul 21, 2026

Copy link
Copy Markdown

Deploy Preview for adk-docs-preview ready!

Name Link
🔨 Latest commit 349bead
🔍 Latest deploy log https://app.netlify.com/projects/adk-docs-preview/deploys/6a692d0066838c0008206af2
😎 Deploy Preview https://deploy-preview-1990--adk-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@zyantw
zyantw requested a review from joefernandez July 21, 2026 20:58
zyantw added 3 commits July 21, 2026 15:09
fixed rendering mistakes
Adding a bullet did not work, I created a sub topic to stop the snippet from breaking in the rendering.
@zyantw zyantw self-assigned this Jul 21, 2026
@joefernandez

joefernandez commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Technical Review Verification & Code Citations:

  • In agent_tool.py:L137-L151 (GitHub Link), the AgentTool class constructor accepts include_plugins as a keyword-only argument, defaulting to True.

Test Coverage:

The behavioral expectations described in the PR are thoroughly tested and validated by several unit tests:

  • test_include_plugins_default_true (GitHub Link): Verifies that when include_plugins is omitted, plugins from the parent runner are propagated to the child agent by default.

  • test_include_plugins_explicit_true (GitHub Link): Verifies that when include_plugins=True is explicitly passed, plugins are propagated.

  • test_include_plugins_false (GitHub Link): Verifies that when include_plugins=False is passed, the child agent runs in an isolated environment and does not receive parent plugins.

  • test_include_plugins_true_sub_runner_does_not_close_parent_plugins (GitHub Link): Verifies that parent-owned plugins are not closed/torn down when the child runner finishes execution.

@joefernandez joefernandez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments.

Comment thread docs/tools-custom/function-tools.md
Comment thread docs/tools-custom/function-tools.md Outdated
Comment thread docs/tools-custom/function-tools.md Outdated
Comment thread docs/tools-custom/function-tools.md Outdated
@zyantw
zyantw merged commit 0a9cc3a into main Jul 28, 2026
12 checks passed
@zyantw
zyantw deleted the zyantw-patch-7 branch July 28, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants