Add _err_print_script_error helper methods#2022
Open
Naros wants to merge 1 commit into
Open
Conversation
dsnopek
requested changes
Jul 24, 2026
Collaborator
There was a problem hiding this comment.
Thanks!
I think this should have some #ifdefs to handle the being compiled when targeting Godot 4.7 and earlier. We could maybe have the _err_print_script_error() functions fallback to print_error()?
Also, how are developers meant to call the _err_print_script_error() functions? We need a public API. If we're to match Godot's internals, this would be _err_print_error() with an ErrorHandlerType enum, but maybe it'd be better to add a nicer API to Godot for this (and then have godot-cpp match that)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dsnopek as discussed on RChat, here's the implementations for the "print_script_error" APIs