fix(extensions): resolve core-command dirs via _assets helpers (#3274)

[Noor-ul-ain001]

Closes #3274.

Problem

specify_cli.extensions._load_core_command_names() never discovers the bundled command templates. It computed its candidate command dirs with bespoke Path(__file__) arithmetic that was correct when the code lived at src/specify_cli/extensions.py, but the #3014 move into the package (extensions.py → extensions/__init__.py) pushed the file one directory deeper without updating the .parent counts. Both candidates now resolve to non-existent paths:

env	computed	real
wheel	specify_cli/extensions/core_pack/commands	specify_cli/core_pack/commands
source	src/templates/commands	repo-root templates/commands

Neither exists, so commands_dir.is_dir() is always false and every call silently returns _FALLBACK_CORE_COMMAND_NAMES.

Why it matters

Latent today (the fallback happens to equal the 10 real command stems), but the shadowing guard from #1994 that consumes CORE_COMMAND_NAMES now depends entirely on someone hand-editing the fallback whenever a core command is added or removed — which already happened once (converge was manually appended in #3001). A future add/remove that forgets the fallback would silently desync the guard.

This is the same off-by-one class @mnriem fixed for the presets loader, but in the extensions module.

Fix

Delegate path resolution to the canonical _locate_core_pack / _repo_root resolvers in _assets — the same ones the presets and bundle loaders already use. They are anchored to the package root, so discovery survives future module moves. (_assets is stdlib-only with zero internal imports, so no cycle risk.)

Tests

The existing test_core_command_names_match_bundled_templates can't catch this — the fallback equals the live tree, so a dead loader and a working one look identical. Added three tests that point the resolvers at a temp tree with different command names, proving discovery reads from disk:

• test_load_core_command_names_discovers_from_source_checkout
• test_load_core_command_names_prefers_wheel_core_pack
• test_load_core_command_names_falls_back_when_nothing_found

The first two fail on the pre-fix code (verified by reverting the source change).

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Fixes core-command template discovery for extensions by switching _load_core_command_names() to use the canonical asset path resolvers, preventing future module moves from silently breaking discovery and desyncing the anti-shadowing guard.

Changes:

• Resolve core command directories via _assets._locate_core_pack() (wheel) and _assets._repo_root() (source checkout) instead of Path(__file__) parent-counting.
• Add regression tests that prove discovery reads from disk (and that fallback behavior only triggers when nothing is found).

Show a summary per file

File	Description
src/specify_cli/extensions/__init__.py	Fixes core command discovery by delegating path resolution to _assets helpers and handling missing candidates cleanly.
tests/test_extensions.py	Adds targeted tests that distinguish a live loader from a “dead” loader returning the baked-in fallback.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Low

[mnriem]

Thank you!