C++: Convert qlref tests to inline expectations#22127
Open
owen-mc wants to merge 6 commits into
Open
Conversation
owen-mc
force-pushed
the
cpp/convert-qlref-inline-expectations
branch
2 times, most recently
from
24aac89 to
e1753ae
Compare
Contributor
Author
Rerun has been triggered: 2 restarted 🚀 |
1 similar comment
Contributor
Author
Rerun has been triggered: 2 restarted 🚀 |
Contributor
|
Since I was looking at this already: I see quite some |
owen-mc
force-pushed
the
cpp/convert-qlref-inline-expectations
branch
from
e1753ae to
76d8ae8
Compare
jketema
reviewed
Jul 7, 2026
jketema
left a comment
jketema
left a comment
Contributor
There was a problem hiding this comment.
Got up to query-tests/Security, but need a break 😅
jketema
reviewed
Jul 7, 2026
Contributor
There was a problem hiding this comment.
Final few comments.
I also came across a few lines that now look like:
... // $ ... // $ ...
So two inline expectations. Those probably need to be fixed up too, nut it seems more effective to find those through a grep on the codebase than me flagging them up here.
Note that when a line is marked `// BAD [NOT DETECTED]` but actually has an alert, I assume that the `[NOT DETECTED]` is outdated and should be deleted.
owen-mc
force-pushed
the
cpp/convert-qlref-inline-expectations
branch
from
caaa912 to
19745e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.