Skip to content

Fix PR duplicate check not running on external contributor submissions#2188

Merged
aaronpowell merged 4 commits into
mainfrom
copilot/github-2121-fix-pr-duplication-check
Jul 3, 2026
Merged

Fix PR duplicate check not running on external contributor submissions#2188
aaronpowell merged 4 commits into
mainfrom
copilot/github-2121-fix-pr-duplication-check

Conversation

Copilot AI commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description

The pr-duplicate-check agentic workflow was silently skipping all external contributor PRs. The compiled .lock.yml contained two blocking gates:

  1. Fork repository guardpre_activation had a hard if: condition requiring github.event.pull_request.head.repo.id == github.repository_id, blocking every fork-originated PR entirely.
  2. Team membership gateactivated output was tied to is_team_member == 'true' with GH_AW_REQUIRED_ROLES: "admin,maintainer,write", blocking anyone without write/maintain/admin access.

Fix: two additions to the pr-duplicate-check.md frontmatter, then recompiled with gh aw compile:

on:
  pull_request:
    types: [opened, synchronize, reopened]
    forks: ["*"]   # removes fork repo check
  roles: all       # removes team membership check

The entire pre_activation job is now gone from the generated lock file; activation runs unconditionally for all PR events.


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
  • Other (please specify):

Additional Notes

The .lock.yml is auto-generated (DO NOT EDIT) — only pr-duplicate-check.md was hand-edited; the lock file was regenerated by the compiler. The safe-outputs (add-comment, noop) bound the agent's write surface, so opening this to all contributors is safe.


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

Copilot AI linked an issue Jul 2, 2026 that may be closed by this pull request
GitHub Advanced Security started work on behalf of aaronpowell July 2, 2026 04:33 View session
GitHub Advanced Security finished work on behalf of aaronpowell July 2, 2026 04:33
Add forks: [\"*\"] and roles: all to pr-duplicate-check.md so the
agentic workflow runs for all PR authors, including external contributors
submitting from forks. Previously, the generated lock.yml contained:
- A fork repository check blocking all fork PRs from running
- A team membership check (admin/maintainer/write) blocking external contributors

Recompiled with gh aw compile to regenerate pr-duplicate-check.lock.yml.
The pre_activation job (which held the membership gate) is now removed,
and the activation job runs unconditionally for all pull_request events.

Closes #2121

Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
GitHub Advanced Security started work on behalf of aaronpowell July 2, 2026 04:40 View session
Copilot AI changed the title [WIP] Fix PR duplication check not running on submissions Fix PR duplicate check not running on external contributor submissions Jul 2, 2026
Copilot AI requested a review from aaronpowell July 2, 2026 04:40
GitHub Advanced Security finished work on behalf of aaronpowell July 2, 2026 04:41
@aaronpowell aaronpowell marked this pull request as ready for review July 2, 2026 23:31
Copilot AI review requested due to automatic review settings July 2, 2026 23:31
@github-actions github-actions Bot added the workflow PR touches workflow automation label Jul 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the agentic workflow that checks PRs for duplicate resources so it no longer suppresses execution for PRs opened from forks and by non-team members.

Changes:

  • Expanded the workflow trigger configuration to include fork submissions and remove role-based activation gating.
  • Regenerated the compiled .lock.yml, removing the prior pre_activation gate and associated needs/output wiring.
Show a summary per file
File Description
.github/workflows/pr-duplicate-check.md Updates workflow frontmatter to allow fork PRs and remove role gating.
.github/workflows/pr-duplicate-check.lock.yml Regenerated output reflecting removal of pre_activation and related activation gating.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment thread .github/workflows/pr-duplicate-check.md
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 2, 2026 23:43
GitHub Advanced Security started work on behalf of aaronpowell July 2, 2026 23:44 View session
GitHub Advanced Security finished work on behalf of aaronpowell July 2, 2026 23:45
Comment on lines +4 to +6
pull_request_target:
types: [opened, synchronize, reopened]
roles: all

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment thread .github/workflows/pr-duplicate-check.md
Comment thread .github/workflows/pr-duplicate-check.lock.yml
GitHub Advanced Security started work on behalf of aaronpowell July 3, 2026 00:01 View session
GitHub Advanced Security finished work on behalf of aaronpowell July 3, 2026 00:03
@aaronpowell aaronpowell merged commit 3bd22bc into main Jul 3, 2026
13 checks passed
@aaronpowell aaronpowell deleted the copilot/github-2121-fix-pr-duplication-check branch July 3, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflow PR touches workflow automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR Duplication check isn't running on submissions

4 participants