Fix PR duplicate check not running on external contributor submissions#2188
Merged
Merged
Conversation
Add forks: [\"*\"] and roles: all to pr-duplicate-check.md so the agentic workflow runs for all PR authors, including external contributors submitting from forks. Previously, the generated lock.yml contained: - A fork repository check blocking all fork PRs from running - A team membership check (admin/maintainer/write) blocking external contributors Recompiled with gh aw compile to regenerate pr-duplicate-check.lock.yml. The pre_activation job (which held the membership gate) is now removed, and the activation job runs unconditionally for all pull_request events. Closes #2121 Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix PR duplication check not running on submissions
Fix PR duplicate check not running on external contributor submissions
Jul 2, 2026
aaronpowell
approved these changes
Jul 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the agentic workflow that checks PRs for duplicate resources so it no longer suppresses execution for PRs opened from forks and by non-team members.
Changes:
- Expanded the workflow trigger configuration to include fork submissions and remove role-based activation gating.
- Regenerated the compiled
.lock.yml, removing the priorpre_activationgate and associatedneeds/output wiring.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/pr-duplicate-check.md | Updates workflow frontmatter to allow fork PRs and remove role gating. |
| .github/workflows/pr-duplicate-check.lock.yml | Regenerated output reflecting removal of pre_activation and related activation gating. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Low
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+4
to
+6
| pull_request_target: | ||
| types: [opened, synchronize, reopened] | ||
| roles: all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.mainbranch for this pull request.Description
The
pr-duplicate-checkagentic workflow was silently skipping all external contributor PRs. The compiled.lock.ymlcontained two blocking gates:pre_activationhad a hardif:condition requiringgithub.event.pull_request.head.repo.id == github.repository_id, blocking every fork-originated PR entirely.activatedoutput was tied tois_team_member == 'true'withGH_AW_REQUIRED_ROLES: "admin,maintainer,write", blocking anyone without write/maintain/admin access.Fix: two additions to the
pr-duplicate-check.mdfrontmatter, then recompiled withgh aw compile:The entire
pre_activationjob is now gone from the generated lock file;activationruns unconditionally for all PR events.Type of Contribution
Additional Notes
The
.lock.ymlis auto-generated (DO NOT EDIT) — onlypr-duplicate-check.mdwas hand-edited; the lock file was regenerated by the compiler. The safe-outputs (add-comment,noop) bound the agent's write surface, so opening this to all contributors is safe.By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.