Add pester-should-migration skill (experimental) by nohwnd · Pull Request #2164 · github/awesome-copilot

nohwnd · 2026-06-30T15:53:07Z

What

Adds a new pester-should-migration skill: a focused guide for migrating Pester tests from the classic v5 Should -Be assertion syntax to the new v6 Should-* assertions (note the hyphen, no space), e.g. Should -Be → Should-Be, Should -Not -BeNullOrEmpty → Should-NotBeNull.

This is a companion to the pester-migration skill (#2163). That skill upgrades a suite across major versions (runtime/mocks/config); this one covers the separate, optional move to the new Should-* operators. In Pester 6 the classic Should -Be keeps working, so adopting Should-* is independent of any version bump.

skills/pester-should-migration/SKILL.md — when to use, a 5-step procedure (find → map → check gotchas → verify → optionally enforce Should.DisableV5), a common-conversions table, and 7 behavioral gotchas.
skills/pester-should-migration/references/assertion-map.md — full operator-by-operator mapping with before/after examples and workarounds for operators that have no direct equivalent.

Experimental / preview

Marked experimental the same way as pester-migration: (experimental) in the title, Experimental (preview) prefix in the description, and a status callout in the body. Every example was empirically verified against Pester 6.0.0-rc2; the new assertions may still change before the 6.0 release.

Validation

npx @microsoft/vally-cli lint skills/pester-should-migration → 3/3 checks passed (spec-compliance, valid-refs, orphan-files). The skills index (docs/README.skills.md) was regenerated to include the new row.

Note on red checks: skill-check and validate-readme currently fail for reasons unrelated to this skill — they are the same pre-existing CI failures seen on #2163. skill-check can't resolve the pinned actions/setup-node SHA, and validate-readme's npm start crashes because package.json pins js-yaml@^5.2.0, whose ESM build has no default export while eng/yaml-parser.mjs does import yaml from "js-yaml". Happy to send a separate infra fix if useful.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

github-actions · 2026-06-30T15:53:32Z

🔒 PR Risk Scan Results

Scanned 3 changed file(s).

Severity	Count
🔴 High	0
🟠 Medium	1
ℹ️ Info	0

Severity	Rule	File	Line	Match
🟠	`package-exec-command`	`docs/README.skills.md`	31	\| [acreadiness-assess](../skills/acreadiness-assess/SKILL.md)<br />`gh skills install github/awesome-copilot acreadiness-assess` \| Run the AgentRC readiness assessment on the curre

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

github-actions · 2026-06-30T15:53:41Z

🔴 Contributor Reputation Check: HIGH risk

Check	Risk
Profile	HIGH
Credential audit	LOW

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

Copilot

Pull request overview

Adds a new experimental Agent Skill, pester-should-migration, to guide migrating classic Pester v5 Should -... assertions to Pester v6 Should-* assertions, and updates the generated skills index to include it.

Changes:

Added skills/pester-should-migration/SKILL.md with a step-by-step migration procedure, common conversions, and behavioral gotchas.
Added skills/pester-should-migration/references/assertion-map.md with a detailed operator mapping and examples/workarounds.
Updated docs/README.skills.md to include the new skill entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
skills/pester-should-migration/SKILL.md	Introduces the skill instructions, workflow, and gotchas for migrating to `Should-*`.
skills/pester-should-migration/references/assertion-map.md	Provides the detailed v5→v6 assertion mapping reference used by the skill.
docs/README.skills.md	Adds the new skill to the skills index.

nohwnd · 2026-06-30T16:01:18Z

Closing in favor of #2163 (pester-migration), which covers the full v3→v4→v5→v6 upgrade path — including the optional v5→v6 Should -* → Should-* assertion changes. Consolidating to avoid two overlapping Pester migration skills.

nohwnd · 2026-06-30T16:02:41Z

Reopened — this is still active (another session is working on it). Please disregard my earlier close note; both this and #2163 remain open for now.

nohwnd · 2026-06-30T16:04:47Z

🔴 Contributor Reputation Check: HIGH risk

Check Risk
Profile HIGH
Credential audit NONE
Maintainers: please review this contributor before merging. See the workflow run for full details. Automated check powered by AGT.

Hello, I own the Pester framework, and also work at Microsoft on testing tools! 👋

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Companion to the pester-migration skill. Focuses on the optional move from the classic v5 `Should -Be` assertion syntax to the new v6 `Should-*` assertions (e.g. `Should -Be` -> `Should-Be`). Includes a full operator-by-operator mapping and the behavioral gotchas (negation as a separate command, BeExactly -> Should-BeString -CaseSensitive, truthy/falsy vs strict bool, BeNullOrEmpty split, collections, pipeline unwrapping). Marked experimental/preview: verified against Pester 6.0.0-rc2; the new Should-* assertions may still change before the 6.0 release. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-07-01T01:58:44Z

🔍 Vally Lint Results

✅ All checks passed

Scope	Checked
Skills	1
Agents	0
Total	1

Severity	Count
❌ Errors	0
⚠️ Warnings	0
ℹ️ Advisories	0

Summary

Level	Finding
ℹ️	npm warn EBADENGINE Unsupported engine {
ℹ️	npm warn EBADENGINE package: 'commander@15.0.0',
ℹ️	npm warn EBADENGINE required: { node: '>=22.12.0' },
ℹ️	npm warn EBADENGINE current: { node: 'v20.20.2', npm: '10.8.2' }
ℹ️	npm warn EBADENGINE }
ℹ️	npm warn deprecated prebuild-install@7.1.3: No longer maintained. Please contact the author of the relevant native addon; alternatives are available.
ℹ️	✅ pester-should-migration (2/2 checks passed)
ℹ️	✓ [spec-compliance] All 1 skill(s) are spec-compliant.
ℹ️	✓ spec-compliance: All spec checks passed.
ℹ️	✓ [valid-refs] All file references across 1 skill(s) are valid.

Full linter output

### Linting skills/pester-should-migration
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: 'commander@15.0.0',
npm warn EBADENGINE   required: { node: '>=22.12.0' },
npm warn EBADENGINE   current: { node: 'v20.20.2', npm: '10.8.2' }
npm warn EBADENGINE }
npm warn deprecated prebuild-install@7.1.3: No longer maintained. Please contact the author of the relevant native addon; alternatives are available.
✅ pester-should-migration (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.

1 skill(s) linted, 1 passed

Copilot

Review details

Files reviewed: 3/3 changed files
Comments generated: 0 new
Review effort level: Low

aaronpowell

Small suggestions here

Address review feedback: drop the time-based, human-oriented preview guidance (release-candidate timing, "as of mid-2026", release-notes link) from the status callout, keeping a lean experimental marker. The agent has no concept of time, so that prose is just extra tokens. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

aaronpowell · 2026-07-02T01:57:05Z

just a merge conflict @nohwnd

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

nohwnd requested a review from aaronpowell as a code owner June 30, 2026 15:53

Copilot AI review requested due to automatic review settings June 30, 2026 15:53

github-actions Bot added new-submission PR adds at least one new contribution skills PR touches skills labels Jun 30, 2026

Copilot started reviewing on behalf of nohwnd June 30, 2026 15:53 View session

github-actions Bot added the needs-review:HIGH Contributor reputation check flagged HIGH risk label Jun 30, 2026

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread skills/pester-should-migration/SKILL.md

Comment thread docs/README.skills.md Outdated

nohwnd force-pushed the add-pester-should-migration-skill branch from 50ad0bf to 53046f5 Compare June 30, 2026 15:56

nohwnd closed this Jun 30, 2026

nohwnd reopened this Jun 30, 2026

Copilot AI review requested due to automatic review settings June 30, 2026 16:05

nohwnd force-pushed the add-pester-should-migration-skill branch from 53046f5 to e6aca1d Compare June 30, 2026 16:05

Copilot started reviewing on behalf of nohwnd June 30, 2026 16:05 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

nohwnd force-pushed the add-pester-should-migration-skill branch from e6aca1d to fca7521 Compare June 30, 2026 16:15

nohwnd mentioned this pull request Jun 30, 2026

Surface the new Pester migration skills in the docs pester/docs#390

Open

2 tasks

Merge branch 'main' into add-pester-should-migration-skill

8567794

Copilot AI review requested due to automatic review settings July 1, 2026 01:56

Copilot started reviewing on behalf of aaronpowell July 1, 2026 01:57 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

aaronpowell reviewed Jul 1, 2026

View reviewed changes

Comment thread skills/pester-should-migration/SKILL.md Outdated

Comment thread skills/pester-should-migration/SKILL.md

aaronpowell enabled auto-merge (squash) July 2, 2026 01:56

Merge branch 'main' into add-pester-should-migration-skill

58f4ca8

Copilot AI review requested due to automatic review settings July 2, 2026 08:54

auto-merge was automatically disabled July 2, 2026 08:54
Head branch was pushed to by a user without write access

Copilot started reviewing on behalf of nohwnd July 2, 2026 08:55 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

Uh oh!

Conversation

nohwnd commented Jun 30, 2026

What

Contents

Experimental / preview

Validation

Uh oh!

github-actions Bot commented Jun 30, 2026

🔒 PR Risk Scan Results

Uh oh!

github-actions Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

nohwnd commented Jun 30, 2026

Uh oh!

nohwnd commented Jun 30, 2026

Uh oh!

nohwnd commented Jun 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Vally Lint Results

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

aaronpowell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aaronpowell commented Jul 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jun 30, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading