Skip to content

refactor(runner-providers): centralize dynamic label selection - #5256

Closed
edersonbrilhante wants to merge 0 commit into
feat-microvm-runner-providerfrom
refactor-dynamic-label-provider-contract
Closed

refactor(runner-providers): centralize dynamic label selection#5256
edersonbrilhante wants to merge 0 commit into
feat-microvm-runner-providerfrom
refactor-dynamic-label-provider-contract

Conversation

@edersonbrilhante

@edersonbrilhante edersonbrilhante commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Description

  • centralize dynamic-label enablement, provider targeting, queue fallback, logging, and dispatch-target construction in the shared webhook selector
  • narrow DynamicLabelProvider to provider-owned validation through getViolations
  • keep EC2 legacy-policy resolution and MicroVM parsing/policy validation inside their provider packages
  • test shared queue selection through injected fake providers while retaining concrete validation tests inside each provider
  • test cross-provider label ownership dynamically from the registered provider type list

This PR is stacked on #5255 and should be reviewed after it.

Test Plan

  • yarn vitest run (58 files, 869 tests passed)
  • yarn eslint libs/runner-providers
  • yarn prettier --check "libs/runner-providers/**/*.ts"
  • yarn workspace @aws-github-runner/webhook build
  • git diff --check

Related Issues

Depends on #5255.

@edersonbrilhante
edersonbrilhante force-pushed the feat-microvm-runner-provider branch from 61e4aa2 to a638a13 Compare August 7, 2026 21:42
@edersonbrilhante
edersonbrilhante force-pushed the refactor-dynamic-label-provider-contract branch from bf1ff57 to a2f0935 Compare August 7, 2026 21:42
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@edersonbrilhante
edersonbrilhante force-pushed the feat-microvm-runner-provider branch from a638a13 to 2384430 Compare August 12, 2026 22:47
@edersonbrilhante
edersonbrilhante force-pushed the refactor-dynamic-label-provider-contract branch from a2f0935 to 55ef5be Compare August 12, 2026 23:05
@edersonbrilhante
edersonbrilhante force-pushed the feat-microvm-runner-provider branch 3 times, most recently from 11c97de to fa2e601 Compare August 13, 2026 11:13
@edersonbrilhante
edersonbrilhante force-pushed the refactor-dynamic-label-provider-contract branch from 55ef5be to fa2e601 Compare August 13, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant