Validate filesystem storage paths#195
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens internal/storage’s filesystem-backed storage by validating object paths before joining them under the storage root, preventing path traversal/absolute-path issues while keeping ListPrefix("") behavior intact.
Changes:
- Introduce
cleanStoragePathvalidation and route all filesystem operations through it viafullPath. - Add
prefixPathto preserve empty-prefix listing semantics forListPrefix. - Expand tests to cover rejection of absolute, traversal, malformed slash/dot-segment, empty, and backslash-containing paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/storage/filesystem.go | Adds centralized storage-path validation and special-cases empty prefix handling for ListPrefix. |
| internal/storage/filesystem_test.go | Expands invalid-path coverage and adds a dedicated test for empty-prefix listing behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Addresses CodeQL alerts for uncontrolled data used in path expressions in internal/storage/filesystem.go.