Skip to content

fix(s7commplus): encode generated SessionKey descriptor - #859

Open
gijzelaerr wants to merge 1 commit into
masterfrom
fix/830-session-key-descriptor
Open

fix(s7commplus): encode generated SessionKey descriptor#859
gijzelaerr wants to merge 1 commit into
masterfrom
fix/830-session-key-descriptor

Conversation

@gijzelaerr

Copy link
Copy Markdown
Owner

Summary

  • pass the newly generated SessionKey directly into SecurityKey descriptor encoding
  • derive the symmetric KeyId from that pending key rather than the inactive connection field
  • reject missing public or symmetric key material instead of emitting plausible zero-key descriptors
  • add deterministic descriptor regression coverage

Validation

  • uv run --frozen --extra test --extra s7commplus pytest -q (1,910 passed, 78 skipped)
  • uv run --frozen pre-commit run --all-files
  • uv build --no-sources

Fixes #830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the generated session key when encoding the V1 SecurityKey descriptor

1 participant