fix: Heatmap bucket limit only enforced for TYPE_INT attributes - #8367
Draft
phacops wants to merge 2 commits into
Draft
fix: Heatmap bucket limit only enforced for TYPE_INT attributes#8367phacops wants to merge 2 commits into
phacops wants to merge 2 commits into
Conversation
Warden finding security-review-fbecf938 Severity: medium Co-Authored-By: Warden <noreply@getsentry.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply MAX_BUCKETS to heatmap x/y bucket counts regardless of attribute type.
Callers can set an arbitrarily large num_y_buckets whenever y_attribute.type is not TYPE_INT (e.g. TYPE_DOUBLE), bypassing MAX_BUCKETS and forcing huge in-memory allocations in range() and [0.0] * num_y_buckets during query result shaping.
Automated fix for Warden finding security-review-fbecf938 (medium, detected by security-review).
Ref #8362