fix: RPC subscription build_request does not re-bind project/org scope - #8366
Draft
phacops wants to merge 1 commit into
Draft
fix: RPC subscription build_request does not re-bind project/org scope#8366phacops wants to merge 1 commit into
phacops wants to merge 1 commit into
Conversation
Warden finding wrdn-authz-cc223c2a Severity: high Co-Authored-By: Warden <noreply@getsentry.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force RPC subscription execution to use the stored subscription project_id and organization, not nested TimeSeriesRequest meta.
RPCSubscriptionData.build_request executes the stored TimeSeriesRequest project_ids/organization_id as-is and never forces them to self.project_id (or metadata org), unlike SnQL which injects project_id at query time—so a mismatched or tampered payload can query another tenant.
Normal from_proto create keeps them in sync; this re-asserts the outer subscription identity at execute time.
Automated fix for Warden finding wrdn-authz-cc223c2a (high, detected by wrdn-authz).
Ref #8362